Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenSSL] Update to 3.0.8 #29530

Merged
merged 2 commits into from Feb 10, 2023
Merged

Conversation

fealebenpae
Copy link
Contributor

Fixes a high severity vulnerability: https://www.openssl.org/news/secadv/20230207.txt.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@flichtenheld
Copy link
Contributor

Fixes #29528
But be aware of openssl/openssl#20234

@FrankXie05 FrankXie05 added the category:port-update The issue is with a library, which is requesting update new revision label Feb 9, 2023
github-actions[bot]
github-actions bot previously approved these changes Feb 9, 2023
@FrankXie05
Copy link
Contributor

We need a patch to apply the changes from PR openssl/openssl#20235 to fix the issue for arm.
Because this problem may not be resolved in the official version for a short time openssl/openssl#20234 (comment)
Error log:
https://dev.azure.com/vcpkg/public/_build/results?buildId=85033&view=artifacts&pathAsName=false&type=publishedArtifacts

libcrypto-shlib-rsa_sup_mul.obj : error LNK2019: unresolved external symbol _umul128 referenced in function _mul_limb
libcrypto-3-arm64.dll : fatal error LNK1120: 1 unresolved externals

@FrankXie05 FrankXie05 linked an issue Feb 9, 2023 that may be closed by this pull request
@fealebenpae
Copy link
Contributor Author

Thanks, I'll add the upstream patch for the ARM64 build issue.

@fealebenpae
Copy link
Contributor Author

I opted to include the patch from openssl/openssl#20244 over openssl/openssl#20235. I'm happy to hold off on this until we see which PR gets merged upstream to make sure we pull in the right patch.

@FrankXie05 FrankXie05 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Feb 10, 2023
flichtenheld added a commit to flichtenheld/openvpn-build that referenced this pull request Feb 10, 2023
See microsoft/vcpkg#29530

Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
flichtenheld added a commit to flichtenheld/openvpn-build that referenced this pull request Feb 10, 2023
See microsoft/vcpkg#29530

Also switch to vcpkg_from_github.

Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
flichtenheld added a commit to OpenVPN/openvpn-build that referenced this pull request Feb 10, 2023
See microsoft/vcpkg#29530

Also switch to vcpkg_from_github.

Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
@JavierMatosD JavierMatosD merged commit 6706cf0 into microsoft:master Feb 10, 2023
@fealebenpae fealebenpae deleted the openssl-update branch March 1, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OpenSSL] update to <3.0.8>
4 participants