[fluidsynth] Update patch and portfile #29636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installation of FluidSynthTargets.cmake was accidentally turned off with the previous version of the patch.
- Remove manpages. - vcpkg_copy_tools already cleans up the bin directories - Copy pdbs after moving the tools. - Remove `enable-debug` as it no longer exists.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
The library dependencies of `FluidSynth::libfluidsynth-OBJ` were not searched for in the Config file.
jimwang118
added
the
category:port-update
jimwang118
requested changes
Feb 14, 2023
Do not set `VCPKG_BUILD_MAKE_TABLES` in the patch.
dg0yt
reviewed
Feb 14, 2023
- Avoid using REQUIRED to find packages. - Check for ALSA on Linux. - Provide versions for pkg-config modules.
jimwang118
approved these changes
Feb 14, 2023
|
All test passed with following triplets: x86-windows Tested usage successfully by the |
JonLiu1993
approved these changes
Feb 14, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.The updated
gentables.patchfrom #29038 accidentally disables the installation ofFluidSynthTargets.cmake.Additionally, this PR cleans up a few things in the portfile:
bindirectories sincevcpkg_copy_tools(AUTO_CLEAN)already handles itenable-debugoption since it no longer exists upstreamTested with default features on:
Tested with all features on: