[glib] Bump to 2.75.3 #29644
Merged
[glib] Bump to 2.75.3 #29644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When consuming glib in CMake through `pkg_check_modules`, libintl (provided by `gettext`) needs to specified in the pc file as `-lintl` without any quotation. Otherwise it is not picked up as a dependency and static linking fails. Also `vcpkg_fixup_pkgconfig` needs to be called before editing pc files.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
The pc file issue with cmake is 6 years old: https://gitlab.kitware.com/cmake/cmake/-/issues/16154. |
Cheney-W
added
the
category:port-update
Cheney-W
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.This PR also fixes an issue when consuming glib in CMake using
pkg_check_moduleswhere libintl is not properly detected and thus breaking static linking.Instead of containing
-lintl, the pc files would contain:"${prefix}/debug/lib/libintl.a"in static release"${prefix}/lib/libintl.a"in static debugFor now the fix in 1f11c33 solves this issue, but any feedback to improve it would be greatly appreciated!
It was tested on: