[folly] Add feature liburing #29684
Merged
[folly] Add feature liburing #29684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilyWangLL
added
category:port-feature
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Cheney-W
previously approved these changes
Feb 16, 2023
BillyONeal
previously requested changes
Feb 16, 2023
| @@ -41,6 +41,7 @@ endif() | |||
| vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS | |||
| FEATURES | |||
| "zlib" CMAKE_REQUIRE_FIND_PACKAGE_ZLIB | |||
| "liburing" WITH_liburing | |||
There was a problem hiding this comment.
I think you also need to patch the __has_includes in here to respect the feature: https://github.com/facebook/folly/search?q=LibUring
There was a problem hiding this comment.
This doesn't need to handle, __has_include will auto check whether liburing.h exists, if it exists, compile the following codes, if it does not exist, it will not compile, and no error will be reported.
JavierMatosD
added
requires:author-response
and removed
info:reviewed
LilyWangLL
dismissed stale reviews from Cheney-W and github-actions
via
a963fe1
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for folly have changed but the version was not updated
version: 2022.10.31.00#4
old SHA: b9c34e53bf193893333116c71ff3e2e0f4d24654
new SHA: 9f031566a728d2a7adf76c1026324cfc993b02a6
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29523, feature
folly[liburing]test pass on Linux.SHA512s are updated for each updated downloadThe "supports" clause reflects platforms that may be fixed by this new versionAny fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.