-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openexr] Fix openexr using unrequested intrinsics #29996
[openexr] Fix openexr using unrequested intrinsics #29996
Conversation
Ok now osx is happy. |
Has this change been submitted to upstream? |
I informed upstream about it. |
upstream has created AcademySoftwareFoundation/openexr#1354 which is the patch added here |
…openexr_using_unrequested_intrinsics
@dan-shaw why does this depend on a different pr? |
I would prefer if upstream merged first |
@MonicaLiu0311 Why should upstream make a new release for such a small and more or less unimportant change? (referring to AcademySoftwareFoundation/openexr#1354 (comment)). Especially since the last release was just last week. I mean if it is CVE fixed here than I would understand that request but this here is just a minor correction for a preprocessor definition correctly allowing AVX which MSVC normally silently ignores/allows (i.e. allowing instructions although the correct arch flag is missing.). @dan-shaw: I understand that but taking microsoft/vcpkg-docs#35 into account I have to assume you have no confidence in this patch although upstream itself created a PR including the patch and upstream CI being green. I find that kind of funny but its ok ;), just make sure i don't need to remember you to merge this PR if upstream is merged. |
this is way to much typing for small patches