Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openexr] Fix openexr using unrequested intrinsics #29996

Merged

Conversation

Neumann-A
Copy link
Contributor

this is way to much typing for small patches

@Neumann-A
Copy link
Contributor Author

Ok now osx is happy.

@Adela0814 Adela0814 added the category:port-bug The issue is with a library, which is something the port should already support label Mar 3, 2023
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Mar 9, 2023
@dan-shaw
Copy link
Contributor

dan-shaw commented Mar 9, 2023

Has this change been submitted to upstream?

@Neumann-A
Copy link
Contributor Author

I informed upstream about it.

@Neumann-A
Copy link
Contributor Author

upstream has created AcademySoftwareFoundation/openexr#1354 which is the patch added here

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Mar 14, 2023
@dan-shaw dan-shaw added the depends:different-pr This PR or Issue depends on a PR which has been filed label Mar 15, 2023
@Neumann-A
Copy link
Contributor Author

@dan-shaw why does this depend on a different pr?

@dan-shaw
Copy link
Contributor

I would prefer if upstream merged first

@Neumann-A
Copy link
Contributor Author

@MonicaLiu0311 Why should upstream make a new release for such a small and more or less unimportant change? (referring to AcademySoftwareFoundation/openexr#1354 (comment)). Especially since the last release was just last week. I mean if it is CVE fixed here than I would understand that request but this here is just a minor correction for a preprocessor definition correctly allowing AVX which MSVC normally silently ignores/allows (i.e. allowing instructions although the correct arch flag is missing.).

@dan-shaw: I understand that but taking microsoft/vcpkg-docs#35 into account I have to assume you have no confidence in this patch although upstream itself created a PR including the patch and upstream CI being green. I find that kind of funny but its ok ;), just make sure i don't need to remember you to merge this PR if upstream is merged.

@dan-shaw dan-shaw merged commit f9a27e0 into microsoft:master Mar 15, 2023
@Neumann-A Neumann-A deleted the fix_openexr_using_unrequested_intrinsics branch March 15, 2023 22:01
@MonicaLiu0311 MonicaLiu0311 removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants