Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libopnmidi] add new port #30015

Merged
merged 1 commit into from
Mar 8, 2023
Merged

[libopnmidi] add new port #30015

merged 1 commit into from
Mar 8, 2023

Conversation

dbarkar
Copy link
Contributor

@dbarkar dbarkar commented Mar 4, 2023

All provided patches are in upstream:
cmake-build-shared-libs-support.patch - Wohlstand/libOPNMIDI@76e4610
cmake-package-export.patch -Wohlstand/libOPNMIDI@a48f3f7
disable-wopn2hpp.patch - Wohlstand/libOPNMIDI@0a91e14
fix-build-without-sequencer.patch -Wohlstand/libOPNMIDI@2c348b3
fix-pmdwin-emulator-include.patch - Wohlstand/libOPNMIDI@81178c3

All features are additive.
There are two experimental emulators (pmdwin-emulator and gx-emulator), should they be included in default features? What's the best practice here?

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@dbarkar dbarkar marked this pull request as ready for review March 4, 2023 12:25
@dbarkar dbarkar changed the title Libopnmidi [libopnmidi] add new port Mar 4, 2023
@jimwang118 jimwang118 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Mar 6, 2023
@jimwang118 jimwang118 closed this Mar 6, 2023
@jimwang118 jimwang118 reopened this Mar 6, 2023
ports/libopnmidi/portfile.cmake Outdated Show resolved Hide resolved
ports/libopnmidi/vcpkg.json Show resolved Hide resolved
@jimwang118
Copy link
Contributor

All feature passed with following triplets:
x86-windows
x64-windows
x64-windows-static

The usage has been tested successfully locally. 

find_package()
target_link_library()

@jimwang118 jimwang118 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Mar 7, 2023
@dan-shaw dan-shaw merged commit 7c729f5 into microsoft:master Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants