Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All provided patches are in upstream:
cmake-build-shared-libs-support.patch - Wohlstand/libOPNMIDI@76e4610
cmake-package-export.patch -Wohlstand/libOPNMIDI@a48f3f7
disable-wopn2hpp.patch - Wohlstand/libOPNMIDI@0a91e14
fix-build-without-sequencer.patch -Wohlstand/libOPNMIDI@2c348b3
fix-pmdwin-emulator-include.patch - Wohlstand/libOPNMIDI@81178c3
All features are additive.
There are two experimental emulators (pmdwin-emulator and gx-emulator), should they be included in default features? What's the best practice here?
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.