Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libnice-gst] Added libnice-gst port at 0.1.18 #30567

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

gerard-ryan-immersaview
Copy link
Contributor

This port primarily works around the following dependency cycle where libnice enables the GStreamer plugin:

  • libnice -> gstreamer
  • gstreamer -> libnice
New port checklist:
  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@gerard-ryan-immersaview
Copy link
Contributor Author

@microsoft-github-policy-service agree company="ImmersaView Pty Ltd"

@gerard-ryan-immersaview gerard-ryan-immersaview marked this pull request as ready for review March 31, 2023 03:41
@MonicaLiu0311 MonicaLiu0311 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Mar 31, 2023
@MonicaLiu0311
Copy link
Contributor

MonicaLiu0311 commented Apr 3, 2023

Thanks a lot for your contribution.

  1. Please modify the deprecated options of libnice and libnice-gst:
CMake Warning at scripts/cmake/vcpkg_configure_meson.cmake:304 (message):
  Options ADDITIONAL_(NATIVE|CROSS)_BINARIES have been deprecated.  Only use
  ADDITIONAL_BINARIES!
Call Stack (most recent call first):
  ports/libnice-gst/portfile.cmake:14 (vcpkg_configure_meson)
  scripts/ports.cmake:147 (include)
  1. Could you please provide the usage?

@MonicaLiu0311
Copy link
Contributor

Please follow the prompts to place the .dll and .pdb files:

-- Performing post-build validation
warning: The following dlls were found in /lib or /debug/lib. Please move them to /bin or /debug/bin, respectively.

    E:\libnice-gst\packages\libnice-gst_x64-windows\lib\gstreamer-1.0\gstnice.dll

warning: The following dlls were found in /lib or /debug/lib. Please move them to /bin or /debug/bin, respectively.

    E:\libnice-gst\packages\libnice-gst_x64-windows\debug\lib\gstreamer-1.0\gstnice.dll

error: Found 2 post-build check problem(s). To submit these ports to curated catalogs, please first correct the portfile: E:\libnice-gst\ports\libnice-gst\portfile.cmake
Stored binary cache: "C:\Users\v-liumonica\AppData\Local\vcpkg\archives\05\05d905f560f1703323a0145c9fab51804868bdef9da5da673eef5abc98fda8d2.zip"
Elapsed time to handle libnice-gst:x64-windows: 44 s
Total install time: 48 s

MonicaLiu0311
MonicaLiu0311 previously approved these changes Apr 4, 2023
scripts/ci.baseline.txt Outdated Show resolved Hide resolved
…bnice to 0.1.21

Co-authored-by: Gerard Ryan <gerard.ryan@immersaview.com>
@gerard-ryan-immersaview
Copy link
Contributor Author

I believe I have addressed all your feedback

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Apr 4, 2023
@vicroms vicroms merged commit 5b8f3e0 into microsoft:master Apr 5, 2023
@gerard-ryan-immersaview gerard-ryan-immersaview deleted the gstnice-port branch April 5, 2023 03:10
@gerard-ryan-immersaview gerard-ryan-immersaview restored the gstnice-port branch April 5, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants