[wangle]:fix dependency #30792
Merged
[wangle]:fix dependency #30792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg0yt
reviewed
Apr 12, 2023
There was a problem hiding this comment.
I think it would be good to try harder to minimize the patch.
- There is no need to change
OpenSSL_LIBRARIES(unless you relly want and have targets everywhere, or are affected by CMake reordering static link libraries for mixe use). - Personally I prefer to group all changes locally to
find_package, e.g.-find_package(Glog REQUIRED) +find_package(Glog NAMES glog CONFIG REQUIRED) # Sets Glog_FOUND +set(GLOG_INCLUDE_DIR "") # If we want to have it initialized +set(GLOG_LIBRARIES glog::glog) # No patching of multiple `$[GLOG_LIBRARIES}`
But in general 👍
Adela0814
added
the
category:port-bug
|
Thanks @dg0yt ， I will take a look. |
|
@Adela0814 ,this pr is ready for review. |
Adela0814
added
the
requires:all-feature-testing
Adela0814
reviewed
Apr 26, 2023
| "${SOURCE_PATH}/build/fbcode_builder/CMake/FindZstd.cmake" | ||
| ) | ||
|
|
||
|
|
There was a problem hiding this comment.
I agree that would be nice to remove but I don't want to force the PR build to be out of date over a style change like that. Something to fix next time we touch it. Thanks for pointing it out though!
|
Tested usage and all feature in the following triplets:
|
Adela0814
approved these changes
Apr 26, 2023
Adela0814
added
info:reviewed
|
Thank you! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.