Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gstreamer, gst-rtsp-server, libnice-gst] Move installed plugins into plugins/gstreamer #30817

Merged
merged 1 commit into from
Apr 14, 2023
Merged

[gstreamer, gst-rtsp-server, libnice-gst] Move installed plugins into plugins/gstreamer #30817

merged 1 commit into from
Apr 14, 2023

Conversation

gerard-ryan-immersaview
Copy link
Contributor

This aligns with the behaviour of other ports like QT and GStreamer deadlocks when trying to load glib shared libraries if they are in the plugin directory.

Update existing port checklist:

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@gerard-ryan-immersaview gerard-ryan-immersaview changed the title [gstreamer, libnice-gst] Move installed plugins into plugins/gstreamer [gstreamer, gst-rtsp-server, libnice-gst] Move installed plugins into plugins/gstreamer Apr 13, 2023
@gerard-ryan-immersaview
[gstreamer, gst-rtsp-server, libnice-gst] Move installed plugins into…
925727d 
… plugins/gstreamer

This aligns with the behaviour of other ports like QT and GStreamer
deadlocks when trying to load glib shared libraries if they are in
the plugin directory.
@gerard-ryan-immersaview gerard-ryan-immersaview marked this pull request as ready for review April 13, 2023 08:32
@FrankXie05 FrankXie05 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Apr 13, 2023
@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Apr 14, 2023
@BillyONeal BillyONeal merged commit 6b7352e into microsoft:master Apr 14, 2023
@BillyONeal
Copy link
Member

Thanks!

@gerard-ryan-immersaview gerard-ryan-immersaview deleted the gstreamer-plugin-dir branch April 17, 2023 01:00
@Cheney-W Cheney-W mentioned this pull request Apr 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankXie05 FrankXie05 FrankXie05 approved these changes

Assignees

@FrankXie05 FrankXie05

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gerard-ryan-immersaview @BillyONeal @FrankXie05