Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blend2d, asmjit] Fix blend2d features build and update asmjit to latest commit #30820

Merged
merged 7 commits into from
Apr 17, 2023

Conversation

LilyWangLL
Copy link
Contributor

@LilyWangLL LilyWangLL commented Apr 13, 2023

Fixes #30409

  1. Update asmjit to latest commit, fix blend2d[jit] build error: error: no member named 'instNameIndex' in namespace 'asmjit::a64::InstDB'.
  2. Fix blend2d[core,jit] and blend2d[core,tls] build failed on windows with the following error. This error need install blend2d[futex].
  3. Modify blend2d[logging] depends on blend2d[jit], because its option is under option BLEND2D_NO_JIT.
E:\Lily\0412\buildtrees\blend2d\src\28ab5c6690-1b84f86302.clean\src\blend2d\threading\futex.cpp(34): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
E:\Lily\0412\buildtrees\blend2d\src\28ab5c6690-1b84f86302.clean\src\blend2d\threading\futex.cpp(34): error C2146: syntax error: missing ';' before identifier 'futexWinAPI'
E:\Lily\0412\buildtrees\blend2d\src\28ab5c6690-1b84f86302.clean\src\blend2d\threading\futex.cpp(42): error C2039: 'futexWinAPI': is not a member of 'BLFutex'
E:\Lily\0412\buildtrees\blend2d\src\28ab5c6690-1b84f86302.clean\src\blend2d\threading\futex.cpp(34): note: see declaration of 'BLFutex'
E:\Lily\0412\buildtrees\blend2d\src\28ab5c6690-1b84f86302.clean\src\blend2d\threading\futex.cpp(42): error C2065: 'futexWinAPI': undeclared identifier
E:\Lily\0412\buildtrees\blend2d\src\28ab5c6690-1b84f86302.clean\src\blend2d\threading\futex.cpp(42): error C2039: 'FutexWinAPI': is not a member of 'BLFutex'
E:\Lily\0412\buildtrees\blend2d\src\28ab5c6690-1b84f86302.clean\src\blend2d\threading\futex.cpp(34): note: see declaration of 'BLFutex'
E:\Lily\0412\buildtrees\blend2d\src\28ab5c6690-1b84f86302.clean\src\blend2d\threading\futex.cpp(42): error C3083: 'FutexWinAPI': the symbol to the left of a '::' must be a type
E:\Lily\0412\buildtrees\blend2d\src\28ab5c6690-1b84f86302.clean\src\blend2d\threading\futex.cpp(42): error C2039: 'WaitOnAddressFunc': is not a member of 'BLFutex'
E:\Lily\0412\buildtrees\blend2d\src\28ab5c6690-1b84f86302.clean\src\blend2d\threading\futex.cpp(34): note: see declaration of 'BLFutex'
E:\Lily\0412\buildtrees\blend2d\src\28ab5c6690-1b84f86302.clean\src\blend2d\threading\futex.cpp(42): error C2065: 'WaitOnAddressFunc': undeclared identifier
E:\Lily\0412\buildtrees\blend2d\src\28ab5c6690-1b84f86302.clean\src\blend2d\threading\futex.cpp(42): error C2146: syntax error: missing ';' before identifier 'GetProcAddress'

The usage of blend2d and asmjit test passed on x64-windows.
All features of blend2d passed on the following triplets:

x64-windows
x64-linux
x64-osx
  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Apr 13, 2023
@LilyWangLL LilyWangLL marked this pull request as ready for review April 14, 2023 02:02
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Apr 17, 2023
@BillyONeal BillyONeal merged commit 6913327 into microsoft:master Apr 17, 2023
@BillyONeal
Copy link
Member

Thanks for the fixes!

@LilyWangLL LilyWangLL deleted the dev/LilyWang/issue30409 branch April 18, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[blend2d] Build error
3 participants