[qt5compat] add proper error message #30829
Conversation
ports/qt5compat/portfile.cmake
Outdated
| @@ -19,7 +19,12 @@ INVERTED_FEATURES | |||
|
|
|||
| #For iconv feature to work the following must be true: | |||
| #CONDITION NOT FEATURE_icu AND FEATURE_textcodec AND NOT WIN32 AND NOT QNX AND NOT ANDROID AND NOT APPLE AND WrapIconv_FOUND | |||
| #TODO: check if qtbase was built with ICU and fail if iconv is given here. | |||
| if("iconv" IN_LIST FEATURES) | |||
| file(READ ${CURRENT_INSTALLED_DIR}/share/qtbase/vcpkg_abi_info.txt qtbase_abi_info) | |||
There was a problem hiding this comment.
I think we are opposed to digging around in vcpkg_abi_info.txt like this because it makes that contractual in a way it isn't currently.
Yes I know vtk does that, I'm not sure we should have done it there either...
There was a problem hiding this comment.
we can install a vcpkg-port-config.cmake to make this stuff visible for downstream ports.
There was a problem hiding this comment.
Yeah, that these features act as alternatives is bad but given that this is the status quo not going to ask you to rip that out for now; but if you're wanting a dependent package to publish configuration information please make that explicit as @Neumann-A suggests rather than reverse engineering it based on an internal file format and the feature's name.
ports/qt5compat/portfile.cmake
Outdated
| @@ -19,7 +19,12 @@ INVERTED_FEATURES | |||
|
|
|||
| #For iconv feature to work the following must be true: | |||
| #CONDITION NOT FEATURE_icu AND FEATURE_textcodec AND NOT WIN32 AND NOT QNX AND NOT ANDROID AND NOT APPLE AND WrapIconv_FOUND | |||
| #TODO: check if qtbase was built with ICU and fail if iconv is given here. | |||
| if("iconv" IN_LIST FEATURES) | |||
| file(READ ${CURRENT_INSTALLED_DIR}/share/qtbase/vcpkg_abi_info.txt qtbase_abi_info) | |||
There was a problem hiding this comment.
Yeah, that these features act as alternatives is bad but given that this is the status quo not going to ask you to rip that out for now; but if you're wanting a dependent package to publish configuration information please make that explicit as @Neumann-A suggests rather than reverse engineering it based on an internal file format and the feature's name.
JonLiu1993
added
category:port-feature
autoantwort
force-pushed
the
qt5compat-error
branch
4 times, most recently
from
1395ee3
to
35b232e
Compare
autoantwort
force-pushed
the
qt5compat-error
branch
from
35b232e
to
a6ddb7a
Compare
|
Thank you! |
JonLiu1993
added
info:reviewed
The
iconvfeature does not work when qtbase is build withicu. Add an explicit error message.