New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[salome-med-fichier] new port #30893
Conversation
Usage test passed with x64-windows triplet:
|
ports/med-fichier/portfile.cmake
Outdated
@@ -0,0 +1,81 @@ | |||
# This library cannot easily be found only. Be aware that the original source repository is not accessible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the source repo https://git.salome-platform.org/gitweb/?p=modules/med.git ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. That is something different which even depends on med-fichier via salome-kernel. I also have a port for salome-med which i'll add later if i got the other deps for it in. There is also somewhere a webpage somewhere explaining the difference between all those med named stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tagging requires: |
A few links to read: |
Right, the question is whether we are willing to include such a library in the curated catalog when it seems to have no accountable upstream in the first place. |
If it is good enough to be packaged by major linux distros (also as |
https://repology.org/project/libmedc/versions Only shows Alpine. When I Googled all I found was that entry for the Debian package. When I try to look at salome-platform.org they seem to be one of those 'tell us all of your information and then we'll give you sources' outfits like cudnn, which we similarly don't index. However, as part of writing this reply I tried messing with repology's URI, and https://repology.org/project/med-fichier/versions redirects to https://repology.org/project/med/versions . But that naming suggests https://git.salome-platform.org/gitweb/?p=modules/med.git and you said this is something else. The fedora package redirects to https://www.salome-platform.org/user-section/about/med which is a 404. I'm just saying this is confusing enough that I want a 2nd opinion, not that I personally would argue against merging this. |
This is the salome "module" which is probably ParaMEDMEM from the who is who link (at least if I look at the file tree it looks like that ).
Better look at the actual build recipes of the different distros where they download from https://files.salome-platform.org/Salome/other/med-${VERSION}.tar.gz . (Note that this is in the subfolder "other" which turns out to be med-fichier) |
@ras0219-msft @vicroms @dan-shaw @JavierMatosD @markle11m and I discussed this today. Open questions:
We think this is a good question but aren't prepared to make a policy statement yet. (It is a good point) |
med-fichier is internally hosted by EDF R&D. salome platform is used by EDF R&D and partly maintained by it.
if i member correctly the debian mirror is a few minor versions behind the salome version and does not have the CMake build system. I would rather use the salome version since it seems to be nearer to the real source even if it adds the cmake build. |
@JavierMatosD @dan-shaw @ras0219-msft @vicroms and I talked about this today. None of us like the name but we don't think anyone else is going to stomp on it. In the interest of containing potential confusion, would you accept |
Thanks! |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.removes tag from #13752