Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[folly] Update to version 2018.03.19.00 #3094

Merged
merged 2 commits into from
Mar 28, 2018

Conversation

KindDragon
Copy link
Contributor

Somehow vcpkg remove from folly-targets.cmake almost all dependencies.

Generated file contain:

set_target_properties(Folly::folly PROPERTIES
  INTERFACE_COMPILE_DEFINITIONS "_CRT_NONSTDC_NO_WARNINGS;_CRT_SECURE_NO_WARNINGS;_SCL_SECURE_NO_WARNINGS;_STL_EXTRA_DISABLED_WARNINGS=4774 4987;\$<\$<BOOL:ON>:_HAS_AUTO_PTR_ETC=1>;\$<\$<BOOL:ON>:WIN32_LEAN_AND_MEAN>"
  INTERFACE_COMPILE_OPTIONS "/EHa;/GF;/Zc:referenceBinding;/Zc:rvalueCast;/Zc:implicitNoexcept;/Zc:strictStrings;/Zc:threadSafeInit;/Zc:throwingNew;\$<\$<BOOL:ON>:/std:c++latest>;\$<\$<BOOL:ON>:/permissive->;/wd4191;/wd4291;/wd4309;/wd4310;/wd4366;/wd4587;/wd4592;/wd4628;/wd4723;/wd4724;/wd4868;/wd4996;/wd4068;/wd4091;/wd4146;/wd4800;/wd4018;/wd4365;/wd4388;/wd4389;/wd4100;/wd4459;/wd4505;/wd4701;/wd4702;/wd4061;/wd4127;/wd4200;/wd4201;/wd4296;/wd4316;/wd4324;/wd4355;/wd4371;/wd4435;/wd4514;/wd4548;/wd4574;/wd4582;/wd4583;/wd4619;/wd4623;/wd4625;/wd4626;/wd4647;/wd4668;/wd4706;/wd4710;/wd4711;/wd4714;/wd4820;/wd5026;/wd5027;/wd5031;/we4099;/we4129;/we4566"
  INTERFACE_INCLUDE_DIRECTORIES "D:/Work/vcpkg/installed/x64-windows/include;D:/Work/vcpkg/installed/x64-windows/include;D:/Work/vcpkg/installed/x64-windows/include;D:/Work/vcpkg/installed/x64-windows/include;D:/Work/vcpkg/installed/x64-windows/include;${_IMPORT_PREFIX}/include"
  INTERFACE_LINK_LIBRARIES "D:/Work/vcpkg/installed/x64-windows/lib/boost_context-vc140-mt.lib;D:/Work/vcpkg/installed/x64-windows/lib/boost_chrono-vc140-mt.lib;D:/Work/vcpkg/installed/x64-windows/lib/boost_date_time-vc140-mt.lib;D:/Work/vcpkg/installed/x64-windows/lib/boost_filesystem-vc140-mt.lib;D:/Work/vcpkg/installed/x64-windows/lib/boost_program_options-vc140-mt.lib;D:/Work/vcpkg/installed/x64-windows/lib/boost_regex-vc140-mt.lib;D:/Work/vcpkg/installed/x64-windows/lib/boost_system-vc140-mt.lib;D:/Work/vcpkg/installed/x64-windows/lib/boost_thread-vc140-mt.lib;D:/Work/vcpkg/installed/x64-windows/lib/boost_atomic-vc140-mt.lib;D:/Work/vcpkg/installed/x64-windows/lib/double-conversion.lib;D:/Work/vcpkg/installed/x64-windows/lib/ssleay32.lib;D:/Work/vcpkg/installed/x64-windows/lib/libeay32.lib;D:/Work/vcpkg/installed/x64-windows/lib/zlib.lib;D:/Work/vcpkg/installed/x64-windows/lib/bz2.lib;D:/Work/vcpkg/installed/x64-windows/lib/lzma.lib;Iphlpapi.lib;Ws2_32.lib;gflags;glog::glog;event"
)

But installed file only this libraries:

set_target_properties(Folly::folly PROPERTIES
  INTERFACE_COMPILE_DEFINITIONS "_CRT_NONSTDC_NO_WARNINGS;_CRT_SECURE_NO_WARNINGS;_SCL_SECURE_NO_WARNINGS;_STL_EXTRA_DISABLED_WARNINGS=4774 4987;\$<\$<BOOL:ON>:_HAS_AUTO_PTR_ETC=1>;\$<\$<BOOL:ON>:WIN32_LEAN_AND_MEAN>"
  INTERFACE_COMPILE_OPTIONS "/EHa;/GF;/Zc:referenceBinding;/Zc:rvalueCast;/Zc:implicitNoexcept;/Zc:strictStrings;/Zc:threadSafeInit;/Zc:throwingNew;\$<\$<BOOL:ON>:/std:c++latest>;\$<\$<BOOL:ON>:/permissive->;/wd4191;/wd4291;/wd4309;/wd4310;/wd4366;/wd4587;/wd4592;/wd4628;/wd4723;/wd4724;/wd4868;/wd4996;/wd4068;/wd4091;/wd4146;/wd4800;/wd4018;/wd4365;/wd4388;/wd4389;/wd4100;/wd4459;/wd4505;/wd4701;/wd4702;/wd4061;/wd4127;/wd4200;/wd4201;/wd4296;/wd4316;/wd4324;/wd4355;/wd4371;/wd4435;/wd4514;/wd4548;/wd4574;/wd4582;/wd4583;/wd4619;/wd4623;/wd4625;/wd4626;/wd4647;/wd4668;/wd4706;/wd4710;/wd4711;/wd4714;/wd4820;/wd5026;/wd5027;/wd5031;/we4099;/we4129;/we4566"
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
  INTERFACE_LINK_LIBRARIES "Iphlpapi.lib;Ws2_32.lib;gflags;glog::glog;event"
)

@ras0219-msft ras0219-msft merged commit 6a3921c into microsoft:master Mar 28, 2018
@ras0219-msft
Copy link
Contributor

Thanks for the update!

The reason we remove those is because the -targets.cmake file needs to be configuration agnostic -- all absolute library paths are tied to a specific configuration (usually release), which would be ABI-incompatible.

The right fix is for us to build up import targets for each of them, which would then properly support release+debug (though in the meantime the user is at least able to link the correct ones).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants