-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[crashpad] Fetch missing dependency for crashpad on linux #30957
Conversation
It sounds like it should be removed from the supports expression and added to ci.baseline.txt. (ci.baseline.txt is the 'something about vcpkg's build lab prevents this from working' where supports is intended to be 'something in this prevents the build from ever working for anyone') |
6423913
to
4a6d005
Compare
Please don't remove |
Right. I actually realized that since one of the latest versions it actually does build with gcc (which definitely wasn't the case before), so I wanted to see if the CI agreed with me. I hadn't realized that there was a restriction on the windows-support. I'll let the pipeline run for now, since I'm waiting to see what the linux-build will do on the ci, if that works I'll put the |
Note that this does not change the fact that crashpad is marked as unsupported, but it makes the build work now with `--allow-unsupported`. The build seems to work fine if the default compiler is set to clang, it does not build with gcc, which is probably why it's marked as unsupported.
4a6d005
to
4528ac3
Compare
Figured it out: It does still need clang, but it no longer uses the system default compiler. So it'll work, even when the default compiler is gcc, as long as clang is installed and in the PATH. So I've added it to the |
Thanks! |
Note that this does not change the fact that crashpad is marked as unsupported, but it makes the build work now with
--allow-unsupported
.The build seems to work fine if the default compiler is set to clang, it does not build with gcc, which is probably why it's marked as unsupported.
./vcpkg x-add-version --all
and committing the result.