Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gtk3] Update #31047

Merged
merged 1 commit into from
Apr 25, 2023
Merged

[gtk3] Update #31047

merged 1 commit into from
Apr 25, 2023

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Apr 22, 2023

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

BillyONeal
BillyONeal approved these changes Apr 22, 2023
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crosses fingers that the hang is fixed

@dg0yt
Copy link
Contributor Author

dg0yt commented Apr 22, 2023

I'm aware of #29018...

@dg0yt
Copy link
Contributor Author

dg0yt commented Apr 22, 2023

... this reminds of the wish to supply a timeout along configure and build commands. It is supported by vcpkg_execute_required_process but not in the higher level functions. With a timeout, we would get failure logs from CI.

@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Apr 23, 2023
@MonicaLiu0311
Copy link
Contributor

All features are tested successfully in the following triplet:
x86-windows
x64-windows

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Apr 23, 2023
@BillyONeal BillyONeal merged commit a27cee0 into microsoft:master Apr 25, 2023
@BillyONeal
Copy link
Member

Thanks for the update!

@dg0yt dg0yt deleted the gtk3 branch April 25, 2023 01:45
@autoantwort autoantwort mentioned this pull request Apr 26, 2023
Closed
@autoantwort
Copy link
Contributor

Hm this caused #31128

@AenBleidd AenBleidd mentioned this pull request May 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@MonicaLiu0311 MonicaLiu0311 MonicaLiu0311 approved these changes

Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dg0yt @MonicaLiu0311 @BillyONeal @autoantwort