[glew] Only set the base address on x86 (32bit) #31084

bold84 · 2023-04-24T09:25:32Z

If this PR updates an existing port, please uncomment and fill out this checklist:

Changes comply with the maintainer guide
SHA512s are updated for each updated download
The "supports" clause reflects platforms that may be fixed by this new version
Any fixed CI baseline entries are removed from that file.
Any patches that are no longer applied are deleted from the port's directory.
The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
Only one version is added to each modified port's versions file.

dg0yt · 2023-04-24T09:52:07Z

This PR should be handled after #30996.

The patch should be submitted upstream. (AFAIU upstream considers the change also for x64.)
Enabling glew:arm64-windows may require fixes to downstream ports which were never tested on arm64-windows (cascaded error).

dg0yt · 2023-04-24T09:54:45Z

Please not that CI won't test the key change unless you remove glew:arm64-windows=fail from scripts/ci.baseline.txt. (This change is part of #30996.)

bold84 · 2023-04-24T09:58:21Z

Alright, I will wait for #30996 to be merged.

bold84 · 2023-04-24T10:14:34Z

nigels-com/glew#384 upstream PR (merged)

dg0yt · 2023-04-24T10:26:25Z

remove glew:arm64-windows=fail from scripts/ci.baseline.txt.

You should really start doing this now.

…m(64)

BillyONeal · 2023-04-24T22:33:59Z

I cancelled the build because it merge conflicts with dg0yt's PR, which just merged. I tried to push a merge for you but you didn't open the PR with permission for me to do that for you.

bold84 · 2023-04-24T22:36:13Z

Hi Billy, I am already working on it... I will push in a few minutes.

ports/glew/portfile.cmake

dg0yt · 2023-04-25T06:06:09Z

ports/blend2d/vcpkg.json

  "description": "Beta 2D Vector Graphics Powered by a JIT Compiler",
  "homepage": "https://github.com/blend2d/blend2d",
  "documentation": "https://blend2d.com/doc/index.html",
  "license": "Zlib",
-  "supports": "!(arm & windows) & !uwp & !wasm32",
+  "supports": "!((arm | arm64) & windows) & !uwp & !wasm32",


arm includes arm64 in these expressions. No change to this port needed.

I mean: This particular change should be reverted.

Oh, I didn't know that. Sure, I will revert the change. Thanks for your feedback!

dg0yt · 2023-04-25T06:08:44Z

ports/osgearth/vcpkg.json

  "description": "osgEarth - Dynamic map generation toolkit for OpenSceneGraph Copyright 2021 Pelican Mapping.",
  "homepage": "https://github.com/gwaldron/osgearth",
  "license": "LGPL-3.0-or-later",
-  "supports": "!(x86 | wasm32)",
+  "supports": "!(((arm | arm64) & windows) | x86 | wasm32)",


arm includes arm64 in these expressions.
However, I'm unsure if this change should be here at all. Do we know that it really doesn't support arm64-windows?

There is a dependency to blend2d and that doesn't build on arm64-windows.

I see. But this dependency is in feature blend2d. And it is not pulled in by default for arm & windows, so this port should just build regardless of glew.

The CI failed because of blend2d, that's why I made the change.

Anyways, I reverted the change. It should fail for the same reason. Then you can advise the best course of action.

dg0yt · 2023-04-25T06:47:22Z

FTR android CI tests were added only a few minutes ago...

dg0yt · 2023-04-25T07:09:43Z

FTR android CI tests were added only a few minutes ago...

xeus on android is a baseline regression, cf. #31098.

bold84 · 2023-04-26T11:31:18Z

@dg0yt ah, you did it already. Thank you!

BillyONeal · 2023-04-27T00:10:05Z

Tried to merge following dg0yt's PR getting merged but still not allowed by the PR OP.

bold84 · 2023-04-27T03:40:20Z

Tried to merge following dg0yt's PR getting merged but still not allowed by the PR OP.

Not sure why this is happening. I haven't done anything for it to be like that. Maybe it's because I used the repo in the namespace of my organization...?

BillyONeal · 2023-04-27T04:01:22Z

Not sure why this is happening. I haven't done anything for it to be like that. Maybe it's because I used the repo in the namespace of my organization...?

It's a checkbox when you make the PR.

bold84 · 2023-04-27T04:20:44Z

@BillyONeal Thank you!

bold84 · 2023-04-27T05:11:18Z

Now there is another issue with osgearth. Git executable can't be found. How does that make sense, when the other PR was just merged?

osgearth config-arm64-windows-out.log

[1/2] "D:/downloads/tools/cmake-3.25.1-windows/cmake-3.25.1-windows-i386/bin/cmake.exe" -E chdir "../../arm64-windows-dbg" "D:/downloads/tools/cmake-3.25.1-windows/cmake-3.25.1-windows-i386/bin/cmake.exe" "D:/buildtrees/osgearth/src/05a55a9c16-32b5b64a2e.clean" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=D:/packages/osgearth_arm64-windows/debug" "-DFETCHCONTENT_FULLY_DISCONNECTED=ON" "-DOSGEARTH_BUILD_TOOLS=OFF" "-DWITH_BLEND2D=OFF" "-DLIB_POSTFIX=" "-DCMAKE_CXX_STANDARD=11" "-DOSGEARTH_BUILD_SHARED_LIBS=1" "-DOSGEARTH_BUILD_EXAMPLES=OFF" "-DOSGEARTH_BUILD_TESTS=OFF" "-DOSGEARTH_BUILD_DOCS=OFF" "-DOSGEARTH_BUILD_PROCEDURAL_NODEKIT=OFF" "-DOSGEARTH_BUILD_TRITON_NODEKIT=OFF" "-DOSGEARTH_BUILD_SILVERLINING_NODEKIT=OFF" "-DWITH_EXTERNAL_TINYXML=ON" "-DCMAKE_JOB_POOL_LINK=console" "-DCMAKE_MAKE_PROGRAM=C:/Program Files/Microsoft Visual Studio/2022/Enterprise/Common7/IDE/CommonExtensions/Microsoft/CMake/Ninja/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/a/1/s/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=arm64-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v143" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/a/1/s/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=arm64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=C:/a/1/s" "-D_VCPKG_INSTALLED_DIR=D:/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-DOSGEARTH_BUILD_TOOLS=OFF" -- The C compiler identification is MSVC 19.35.32217.1 -- The CXX compiler identification is MSVC 19.35.32217.1 -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working C compiler: C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.35.32215/bin/Hostx64/arm64/cl.exe - skipped -- Detecting C compile features -- Detecting C compile features - done -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.35.32215/bin/Hostx64/arm64/cl.exe - skipped -- Detecting CXX compile features -- Detecting CXX compile features - done -- Found OpenGL: opengl32 -- Found Fontconfig: D:/installed/arm64-windows/debug/lib/fontconfig.lib (found version "2.14.2") -- Found Freetype: optimized;D:/installed/arm64-windows/lib/freetype.lib;debug;D:/installed/arm64-windows/debug/lib/freetyped.lib (found version "2.12.1") -- Found EXPAT: optimized;D:/installed/arm64-windows/lib/libexpat.lib;debug;D:/installed/arm64-windows/debug/lib/libexpatd.lib (found version "2.5.0") -- Found OpenSSL: optimized;D:/installed/arm64-windows/lib/libcrypto.lib;debug;D:/installed/arm64-windows/debug/lib/libcrypto.lib (found suitable version "3.1.0", minimum required is "3") -- Found ZLIB: optimized;D:/installed/arm64-windows/lib/zlib.lib;debug;D:/installed/arm64-windows/debug/lib/zlibd.lib (found suitable version "1.2.13", minimum required is "1") -- Found Protobuf: optimized;D:/installed/arm64-windows/lib/libprotobuf.lib;debug;D:/installed/arm64-windows/debug/lib/libprotobufd.lib (found version "3.21.12") -- Performing Test CMAKE_HAVE_LIBC_PTHREAD -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed -- Looking for pthread_create in pthreads -- Looking for pthread_create in pthreads - not found -- Looking for pthread_create in pthread -- Looking for pthread_create in pthread - not found -- Found Threads: TRUE -- Found BZip2: optimized;D:/installed/arm64-windows/lib/bz2.lib;debug;D:/installed/arm64-windows/debug/lib/bz2d.lib (found version "1.0.8") -- Looking for BZ2_bzCompressInit -- Looking for BZ2_bzCompressInit - found -- Found OpenSSL: optimized;D:/installed/arm64-windows/lib/libcrypto.lib;debug;D:/installed/arm64-windows/debug/lib/libcrypto.lib (found version "3.1.0") -- Found ZLIB: optimized;D:/installed/arm64-windows/lib/zlib.lib;debug;D:/installed/arm64-windows/debug/lib/zlibd.lib (found version "1.2.13") -- Found GDAL 3.6.4 -- Found OSG version 3.6.5 -- Creating D:/buildtrees/osgearth/arm64-windows-dbg/build_include/osgEarth/BuildConfig.h CMake Warning (dev) at D:/downloads/tools/cmake-3.25.1-windows/cmake-3.25.1-windows-i386/share/cmake-3.25/Modules/FindPackageHandleStandardArgs.cmake:438 (message): The package name passed to `find_package_handle_standard_args` (Git) does not match the name of the calling package (git). This can lead to problems in calling code that expects `find_package` result variables (e.g., `_FOUND`) to follow a certain pattern. Call Stack (most recent call first): D:/downloads/tools/cmake-3.25.1-windows/cmake-3.25.1-windows-i386/share/cmake-3.25/Modules/FindGit.cmake:128 (find_package_handle_standard_args) C:/a/1/s/scripts/buildsystems/vcpkg.cmake:852 (_find_package) src/osgEarth/CMakeLists.txt:506 (find_package) This warning is for project developers. Use -Wno-dev to suppress it.

-- Could NOT find Git (missing: GIT_EXECUTABLE)
-- Building osgEarth as a SHARED library
-- D:/buildtrees/osgearth/arm64-windows-dbg/build_includeD:/buildtrees/osgearth/src/05a55a9c16-32b5b64a2e.clean/srcD:/installed/arm64-windows/includeD:/installed/arm64-windows/includeD:/buildtrees/osgearth/arm64-windows-dbg/src/osgEarthD:/installed/arm64-windows/includeD:/installed/arm64-windows/include
-- INCDIR: D:/packages/osgearth_arm64-windows/debug/include
-- Configuring done
-- Generating done
CMake Warning:
Manually-specified variables were not used by the project:

CMAKE_INSTALL_BINDIR
CMAKE_INSTALL_LIBDIR
FETCHCONTENT_FULLY_DISCONNECTED
LIB_POSTFIX
_VCPKG_ROOT_DIR

dg0yt · 2023-04-27T05:18:57Z

I looked at the new osgearth error logs. My suggestion is to change that port's supports to

  "supports": "!(arm | x86 | wasm32)",

AFAICS this doesn't remove any triplet which is currently tested in CI.
Our issue is with x64 intrinsics in one driver, but there seems to be another issues at least with arm64-osx:
gwaldron/osgearth#2220

The restriction can be lifted in a separate PR with the next update, or with patching. Similar to our ping-pong with glew: I just transformed the existing restriction. The hard work is lifting the restriction...

dg0yt · 2023-04-27T05:22:53Z

We were posting in parallel ... the git warning is harmless (and not related to arm64-windows). The real error is during build, cf. install log.

bold84 · 2023-04-27T05:43:13Z

@dg0yt ah yes... I didn't notice that.

osgearth install-arm64-windows-dbg-out.log

[328/445] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1435~1.322\bin\Hostx64\arm64\cl.exe /TP -DCURL_STATICLIB -DOSGEARTH_HAVE_GEOS -DOSGEARTH_HAVE_MBTILES -DOSGEARTH_HAVE_MVT -DOSGEARTH_HAVE_PROTOBUF -DOSGEARTH_HAVE_SQLITE3 -DOSGEARTH_LIBRARY -DTIXML_USE_STL -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D__STDC_FORMAT_MACROS -DosgEarth_EXPORTS -ID:\buildtrees\osgearth\arm64-windows-dbg\build_include -ID:\buildtrees\osgearth\src\05a55a9c16-32b5b64a2e.clean\src -ID:\buildtrees\osgearth\arm64-windows-dbg\src\osgEarth -external:ID:\installed\arm64-windows\include -external:ID:\installed\arm64-windows\include\geos -external:W0 /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1 /showIncludes /Fosrc\osgEarth\CMakeFiles\osgEarth.dir\ModelNode.cpp.obj /Fdsrc\osgEarth\CMakeFiles\osgEarth.dir\ /FS -c D:\buildtrees\osgearth\src\05a55a9c16-32b5b64a2e.clean\src\osgEarth\ModelNode.cpp [328/445] cmd.exe /C "cd . && D:\downloads\tools\cmake-3.25.1-windows\cmake-3.25.1-windows-i386\bin\cmake.exe -E vs_link_dll --intdir=src\osgEarth\CMakeFiles\osgEarth.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\mt.exe --manifests -- C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1435~1.322\bin\Hostx64\arm64\link.exe @CMakeFiles\osgEarth.rsp /out:lib\osgEarthd.dll /implib:lib\osgEarthd.lib /pdb:lib\osgEarthd.pdb /dll /version:3.3 /machine:ARM64 /nologo /debug /INCREMENTAL /NODEFAULTLIB:MSVCRT && cd ." [351/445] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1435~1.322\bin\Hostx64\arm64\cl.exe /TP -DCURL_STATICLIB -DOSGEARTH_HAVE_MBTILES -DOSGEARTH_HAVE_PROTOBUF -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -Dosgdb_fastdxt_EXPORTS -ID:\buildtrees\osgearth\arm64-windows-dbg\build_include -ID:\buildtrees\osgearth\src\05a55a9c16-32b5b64a2e.clean\src -external:ID:\installed\arm64-windows\include -external:ID:\installed\arm64-windows\include\geos -external:W0 /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1 /showIncludes /Fosrc\osgEarthDrivers\fastdxt\CMakeFiles\osgdb_fastdxt.dir\intrinsic.cpp.obj /Fdsrc\osgEarthDrivers\fastdxt\CMakeFiles\osgdb_fastdxt.dir\ /FS -c D:\buildtrees\osgearth\src\05a55a9c16-32b5b64a2e.clean\src\osgEarthDrivers\fastdxt\intrinsic.cpp FAILED: src/osgEarthDrivers/fastdxt/CMakeFiles/osgdb_fastdxt.dir/intrinsic.cpp.obj C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1435~1.322\bin\Hostx64\arm64\cl.exe /TP -DCURL_STATICLIB -DOSGEARTH_HAVE_MBTILES -DOSGEARTH_HAVE_PROTOBUF -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -Dosgdb_fastdxt_EXPORTS -ID:\buildtrees\osgearth\arm64-windows-dbg\build_include -ID:\buildtrees\osgearth\src\05a55a9c16-32b5b64a2e.clean\src -external:ID:\installed\arm64-windows\include -external:ID:\installed\arm64-windows\include\geos -external:W0 /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1 /showIncludes /Fosrc\osgEarthDrivers\fastdxt\CMakeFiles\osgdb_fastdxt.dir\intrinsic.cpp.obj /Fdsrc\osgEarthDrivers\fastdxt\CMakeFiles\osgdb_fastdxt.dir\ /FS -c D:\buildtrees\osgearth\src\05a55a9c16-32b5b64a2e.clean\src\osgEarthDrivers\fastdxt\intrinsic.cpp C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.35.32215\include\emmintrin.h(20): fatal error C1189: #error: This header is specific to X86, X64 and ARM64EC targets [352/445] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1435~1.322\bin\Hostx64\arm64\cl.exe /TP -DCURL_STATICLIB -DOSGEARTH_HAVE_MBTILES -DOSGEARTH_HAVE_PROTOBUF -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -Dosgdb_fastdxt_EXPORTS -ID:\buildtrees\osgearth\arm64-windows-dbg\build_include -ID:\buildtrees\osgearth\src\05a55a9c16-32b5b64a2e.clean\src -external:ID:\installed\arm64-windows\include -external:ID:\installed\arm64-windows\include\geos -external:W0 /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1 /showIncludes /Fosrc\osgEarthDrivers\fastdxt\CMakeFiles\osgdb_fastdxt.dir\util.cpp.obj /Fdsrc\osgEarthDrivers\fastdxt\CMakeFiles\osgdb_fastdxt.dir\ /FS -c D:\buildtrees\osgearth\src\05a55a9c16-32b5b64a2e.clean\src\osgEarthDrivers\fastdxt\util.cpp D:\buildtrees\osgearth\src\05a55a9c16-32b5b64a2e.clean\src\osgEarthDrivers\fastdxt\util.cpp(241): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data D:\buildtrees\osgearth\src\05a55a9c16-32b5b64a2e.clean\src\osgEarthDrivers\fastdxt\util.cpp(244): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [373/445] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1435~1.322\bin\Hostx64\arm64\cl.exe /TP -DCURL_STATICLIB -DOSGEARTH_HAVE_MBTILES -DOSGEARTH_HAVE_PROTOBUF -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -Dosgdb_fastdxt_EXPORTS -ID:\buildtrees\osgearth\arm64-windows-dbg\build_include -ID:\buildtrees\osgearth\src\05a55a9c16-32b5b64a2e.clean\src -external:ID:\installed\arm64-windows\include -external:ID:\installed\arm64-windows\include\geos -external:W0 /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1 /showIncludes /Fosrc\osgEarthDrivers\fastdxt\CMakeFiles\osgdb_fastdxt.dir\FastDXTImageProcessor.cpp.obj /Fdsrc\osgEarthDrivers\fastdxt\CMakeFiles\osgdb_fastdxt.dir\ /FS -c D:\buildtrees\osgearth\src\05a55a9c16-32b5b64a2e.clean\src\osgEarthDrivers\fastdxt\FastDXTImageProcessor.cpp D:\buildtrees\osgearth\src\05a55a9c16-32b5b64a2e.clean\src\osgEarthDrivers\fastdxt\FastDXTImageProcessor.cpp(131): warning C4018: '<': signed/unsigned mismatch [380/445] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1435~1.322\bin\Hostx64\arm64\cl.exe /TP -DOSGEARTH_HAVE_MBTILES -DOSGEARTH_HAVE_PROTOBUF -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -Dosgdb_osgearth_viewpoints_EXPORTS -ID:\buildtrees\osgearth\arm64-windows-dbg\build_include -ID:\buildtrees\osgearth\src\05a55a9c16-32b5b64a2e.clean\src -external:ID:\installed\arm64-windows\include -external:ID:\installed\arm64-windows\include\geos -external:W0 /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1 /showIncludes /Fosrc\osgEarthDrivers\viewpoints\CMakeFiles\osgdb_osgearth_viewpoints.dir\ViewpointsExtension.cpp.obj /Fdsrc\osgEarthDrivers\viewpoints\CMakeFiles\osgdb_osgearth_viewpoints.dir\ /FS -c D:\buildtrees\osgearth\src\05a55a9c16-32b5b64a2e.clean\src\osgEarthDrivers\viewpoints\ViewpointsExtension.cpp ninja: build stopped: subcommand failed.

If you are not already on it, I will have a look at it.

bold84 · 2023-04-27T06:44:46Z

@dg0yt Yeah, I will follow your suggestion.
The issue seems to be a bigger one on osgearth's side.

Cheney-W · 2023-04-28T05:06:28Z

versions/g-/glew.json

+      "port-version": 3
+    },
+    {
+      "git-tree": "ca41377df059245d9a8b18c459e67b81a3a51975",


Please don't change the data of the old version.

Ah yes, I messed up the reversion. I'll fix it. Thank you.

ports/glew/portfile.cmake

BillyONeal

I am happy so long as the comment I asked for is added.

glew-patch.patch

Co-authored-by: Billy O'Neal <bion@microsoft.com>

bold84 · 2023-04-28T23:38:37Z

I am happy so long as the comment I asked for is added.

glew-patch.patch

Done. I'll update the version in 10-15 minutes. I just woke up and am not on my computer yet. 😅

dg0yt

👍 and thanks to @bold84.

Cheney's comment got fixed :)

BillyONeal · 2023-05-01T18:46:56Z

Thanks again!

Only set the base address on Windows x86.

ef4f29e

bold84 mentioned this pull request Apr 24, 2023

[pcl] Devendor zlib, cleanup, enable arm64-windows #30996

Merged

7 tasks

Cheney-W self-assigned this Apr 24, 2023

Cheney-W added the category:port-bug The issue is with a library, which is something the port should already support label Apr 24, 2023

Cheney-W added the depends:different-pr This PR or Issue depends on a PR which has been filed label Apr 24, 2023

dg0yt mentioned this pull request Apr 24, 2023

[glew] build failure for arm64-windows #23301

Closed

bold84 changed the title ~~Only set the base address on Windows x86.~~ Only set the base address on x86. Apr 24, 2023

bold84 changed the title ~~Only set the base address on x86.~~ Only set the base address on x86 (32bit) Apr 24, 2023

Only set the base address on x86. Disable osgearth and blend2d for ar…

8c8882e

…m(64)

bold84 force-pushed the glew_base_address_fix branch from 34cc8e2 to 8c8882e Compare April 24, 2023 19:58

Merge remote-tracking branch 'origin/master' into glew_base_address_fix

63cf8a2

ARM64 works now

50b239e

bold84 marked this pull request as ready for review April 24, 2023 22:58

Cheney-W removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Apr 25, 2023

Merge branch 'master' into glew_base_address_fix

dc46a0a

dg0yt reviewed Apr 25, 2023

View reviewed changes

ports/glew/portfile.cmake Outdated Show resolved Hide resolved

Fixed indentation

0bf4452

dg0yt suggested changes Apr 25, 2023

View reviewed changes

Fixed indentation (2nd)

2a7f810

Reverted changes to blend2d and osgearth

5543259

dg0yt mentioned this pull request Apr 25, 2023

Check baseline without parent hashes #31098

Closed

Merge remote-tracking branch 'origin/master' into glew_base_address_fix

63bc9a3

Disable arm builds for osgearth

1006c63

dg0yt mentioned this pull request Apr 27, 2023

[ms-quic] update version to 2.2.0 #29568

Closed

7 tasks

Cheney-W previously requested changes Apr 28, 2023

View reviewed changes

Cheney-W added the requires:author-response label Apr 28, 2023

Reverted change to versions/glew.json

e9e43c2

bold84 requested a review from Cheney-W April 28, 2023 10:04

BillyONeal requested a review from dg0yt April 28, 2023 23:31

BillyONeal reviewed Apr 28, 2023

View reviewed changes

ports/glew/portfile.cmake Outdated Show resolved Hide resolved

BillyONeal previously approved these changes Apr 28, 2023

View reviewed changes

Update ports/glew/portfile.cmake

bfe07e1

Co-authored-by: Billy O'Neal <bion@microsoft.com>

Updated version

d8d0879

bold84 dismissed BillyONeal’s stale review via d8d0879 April 29, 2023 00:18

dg0yt approved these changes Apr 29, 2023

View reviewed changes

BillyONeal merged commit a92f44a into microsoft:master May 1, 2023
15 checks passed

Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels May 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[glew] Only set the base address on x86 (32bit) #31084

[glew] Only set the base address on x86 (32bit) #31084

bold84 commented Apr 24, 2023 •

edited by Cheney-W

Loading

dg0yt commented Apr 24, 2023 •

edited

Loading

dg0yt commented Apr 24, 2023

bold84 commented Apr 24, 2023

bold84 commented Apr 24, 2023 •

edited

Loading

dg0yt commented Apr 24, 2023

BillyONeal commented Apr 24, 2023

bold84 commented Apr 24, 2023

dg0yt Apr 25, 2023

dg0yt Apr 25, 2023

bold84 Apr 25, 2023

dg0yt Apr 25, 2023

bold84 Apr 25, 2023

dg0yt Apr 25, 2023

bold84 Apr 25, 2023

dg0yt commented Apr 25, 2023

dg0yt commented Apr 25, 2023

bold84 commented Apr 26, 2023

BillyONeal commented Apr 27, 2023

bold84 commented Apr 27, 2023

BillyONeal commented Apr 27, 2023

bold84 commented Apr 27, 2023

bold84 commented Apr 27, 2023 •

edited

Loading

dg0yt commented Apr 27, 2023

dg0yt commented Apr 27, 2023

bold84 commented Apr 27, 2023

bold84 commented Apr 27, 2023

Cheney-W Apr 28, 2023

bold84 Apr 28, 2023

BillyONeal left a comment

bold84 commented Apr 28, 2023

dg0yt left a comment

BillyONeal commented May 1, 2023

[glew] Only set the base address on x86 (32bit) #31084

[glew] Only set the base address on x86 (32bit) #31084

Conversation

bold84 commented Apr 24, 2023 • edited by Cheney-W Loading

dg0yt commented Apr 24, 2023 • edited Loading

dg0yt commented Apr 24, 2023

bold84 commented Apr 24, 2023

bold84 commented Apr 24, 2023 • edited Loading

dg0yt commented Apr 24, 2023

BillyONeal commented Apr 24, 2023

bold84 commented Apr 24, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dg0yt commented Apr 25, 2023

dg0yt commented Apr 25, 2023

bold84 commented Apr 26, 2023

BillyONeal commented Apr 27, 2023

bold84 commented Apr 27, 2023

BillyONeal commented Apr 27, 2023

bold84 commented Apr 27, 2023

bold84 commented Apr 27, 2023 • edited Loading

dg0yt commented Apr 27, 2023

dg0yt commented Apr 27, 2023

bold84 commented Apr 27, 2023

bold84 commented Apr 27, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BillyONeal left a comment

Choose a reason for hiding this comment

bold84 commented Apr 28, 2023

dg0yt left a comment

Choose a reason for hiding this comment

BillyONeal commented May 1, 2023

bold84 commented Apr 24, 2023 •

edited by Cheney-W

Loading

dg0yt commented Apr 24, 2023 •

edited

Loading

bold84 commented Apr 24, 2023 •

edited

Loading

bold84 commented Apr 27, 2023 •

edited

Loading