Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gtkmm] update to 4.10.0 #31122

Merged
merged 2 commits into from
Apr 26, 2023
Merged

[gtkmm] update to 4.10.0 #31122

merged 2 commits into from
Apr 26, 2023

Conversation

SchaichAlonso
Copy link
Contributor

Fixes #31121.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Apr 26, 2023
@SchaichAlonso SchaichAlonso marked this pull request as ready for review April 26, 2023 04:26
BillyONeal
BillyONeal reviewed Apr 26, 2023
View reviewed changes
ports/gtkmm/vcpkg.json
"description": "gtkmm is the official C++ interface for the popular GUI library GTK+.",
"homepage": "https://www.gtkmm.org/",
"license": "LGPL-3.0-or-later",
"supports": "!uwp",
"dependencies": [
"atk",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah what happened to all these other gnome dependencies? (I'm worried that they might get found on the system and thus our CI won't catch it but they might still be real dependencies?)

It's likely this change is fine I'm just raising my eyebrows.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi

Especially the atk dependency struck my attention, because this project would use atkmm rather then atk, if it did something with atk to begin with... so I checked the dependency section of meson.build, and removed any dependency that wasn't listed there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

atk will get installed nevertheless, but as a deep-endency of gtk, rather then as a direct dependency of this port

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, makes sense, thanks!

diff output

@MonicaLiu0311
Copy link
Contributor

No feature needs to be tested.

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Apr 26, 2023
@BillyONeal BillyONeal merged commit e5eb69d into microsoft:master Apr 26, 2023
@BillyONeal
Copy link
Member

Thanks for the update and the making-dependencies-crisp!

@SchaichAlonso SchaichAlonso mentioned this pull request Jun 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal left review comments

@MonicaLiu0311 MonicaLiu0311 MonicaLiu0311 approved these changes

Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[gtkmm] update to 4.10.0
3 participants
@SchaichAlonso @MonicaLiu0311 @BillyONeal