New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rcon] add new port #31131
[rcon] add new port #31131
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
portfile.cmake and usage files need a blank line at the end.
problem fixed |
Hi @luckyweNda, since this looks like a new library and it is not listed on repology would you mind changing the port name to something like "luckywenda-rcon"? |
I do not mind changing its port name.But I prefer using my blog domain name instead of using github username as its port name prefix. |
The usage has been tested successfully locally.
|
Co-authored-by: jim wang <122244446+jimwang118@users.noreply.github.com>
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.