Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qt5-imageformats] Move deps to features #31282

Merged
merged 1 commit into from
May 9, 2023
Merged

[qt5-imageformats] Move deps to features #31282

merged 1 commit into from
May 9, 2023

Conversation

Osyotr
Copy link
Contributor

@Osyotr Osyotr commented May 5, 2023

Towards #8213

Jasper is no longer installed by default. Not sure whether freeglut detection should stay (upstream bug?).
Also not sure whether libwebp comment is still relevant.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@LilyWangLL LilyWangLL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 6, 2023
@Osyotr Osyotr marked this pull request as ready for review May 6, 2023 08:11
@LilyWangLL LilyWangLL added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label May 6, 2023
@LilyWangLL LilyWangLL removed the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label May 8, 2023
@LilyWangLL
Copy link
Contributor

All features passed with following triplets:

x86-windows
x64-windows
x64-windows-static

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label May 8, 2023
@vicroms vicroms merged commit fb46486 into microsoft:master May 9, 2023
15 checks passed
@Osyotr Osyotr deleted the qt5-imageformats-features branch May 9, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Osyotr @LilyWangLL @vicroms