-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pcre2] Convert JIT to feature #31294
Conversation
It is currently not failing? |
vcpkg ci doesn't check |
I have tested it locally |
I tested it on osx on the github action ci. and it fail without this fix. I also set these:
|
Can you provide the error logs? |
I will. |
Ah I found it:
|
But then I suggest to make it a feature instead of turning it off completely because it only works on current macs. |
I will try to convert it to a feature. |
b6cc00b
to
7f59107
Compare
20c58fc
to
4e5f85b
Compare
@autoantwort Can you test my port and check I didn't make errors? |
@autoantwort What about the android failing in the ci? |
I think it is a baseline regression not caused by this PR. |
It think that until microsoft/vcpkg-tool#813 is merged, |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Pipeline issue came from #31155. I'm trying to fix it. |
4e5f85b
to
305adb3
Compare
This still must be done. |
I have converted your PR to draft status. When you respond to Victor's suggestion, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags. |
305adb3
to
f9a83fc
Compare
Convert JIT to feature
./vcpkg x-add-version --all
and committing the result.