Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp-async] Add new port #31523

Merged
merged 9 commits into from May 22, 2023
Merged

Conversation

chausner
Copy link
Contributor

This adds the cpp-async library as a new port.

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • x] Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@chausner
Copy link
Contributor Author

The upstream repository uses a vcpkg manifest (https://github.com/microsoft/cpp-async/blob/main/vcpkg.json) but I think the manifests in this repository are independent, right?

@chausner
Copy link
Contributor Author

@davidmatson Are official versioned releases planned for cpp-async? If yes, would you suggest that we wait for the first release before publishing a vcpkg port? This PR is using date-based versioning at the moment since there is no official release yet.

@davidmatson
Copy link
Contributor

@davidmatson Are official versioned releases planned for cpp-async? If yes, would you suggest that we wait for the first release before publishing a vcpkg port? This PR is using date-based versioning at the moment since there is no official release yet.

Good question. I was planning on publishing a separate release zip, but I could tag the current branch as v1.0.0. Thoughts?

And thanks for doing this port!

@chausner chausner marked this pull request as draft May 19, 2023 22:33
@chausner
Copy link
Contributor Author

Good question. I was planning on publishing a separate release zip, but I could tag the current branch as v1.0.0. Thoughts?

If there are official releases, a release tag would make a lot of sense, yes.

And thanks for doing this port!

Thank you for publishing the library. ;)

@davidmatson
Copy link
Contributor

If there are official releases, a release tag would make a lot of sense, yes.

Done - it's v1.0.0 now.

@chausner chausner marked this pull request as ready for review May 20, 2023 16:21
@LilyWangLL LilyWangLL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label May 22, 2023
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label May 22, 2023
@dan-shaw dan-shaw merged commit f2328e8 into microsoft:master May 22, 2023
15 checks passed
@chausner chausner deleted the cpp-async-2023-05-19 branch May 22, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants