Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[coin-or-cbc] Add new port #31607

Merged
merged 57 commits into from
Jul 5, 2023
Merged

[coin-or-cbc] Add new port #31607

merged 57 commits into from
Jul 5, 2023

Conversation

jpfeuffer
Copy link
Contributor

@jpfeuffer jpfeuffer commented May 24, 2023 •
edited
Loading

Revive #7850

@jpfeuffer
Copy link
Contributor Author

@microsoft-github-policy-service agree

@jpfeuffer
Copy link
Contributor Author

jpfeuffer commented May 24, 2023 •
edited
Loading

@Neumann-A Would you mind having a look here? You recently updated all coin recipes. I was trying to use the Buildtools autoconf files, like you did for all other recipes but it fails.

My configure options are pretty much random. I got them from their CI.

@jpfeuffer jpfeuffer changed the title port/cbc port/coin-or-cbc May 24, 2023
@jpfeuffer
Copy link
Contributor Author

jpfeuffer commented May 24, 2023 •
edited
Loading

e.g. on Windows x64:

autoreconf: export WARNINGS=
autoreconf: Entering directory '.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal -I "D:/buildtrees/coin-or-cbc/src/8ad995b231-cec7df5550.clean/BuildTools" --force 
am-wrapper: aclocal: warning: auto-detected versions not found (1.9); falling back to latest available
autoreconf: configure.ac: tracing
autoreconf: configure.ac: not using Libtool
autoreconf: configure.ac: not using Intltool
autoreconf: configure.ac: not using Gtkdoc
autoreconf: running: /usr/bin/autoconf --force
configure.ac:39: error: possibly undefined macro: AC_COIN_CREATE_LIBTOOL
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
configure.ac:45: error: possibly undefined macro: AC_COIN_MAIN_PACKAGEDIR
autoreconf: error: /usr/bin/autoconf failed with exit status: 1

or macOS pretty much the same:

autoreconf: export WARNINGS=
autoreconf: Entering directory '.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal -I "/Users/vagrant/Data/buildtrees/coin-or-cbc/src/8ad995b231-cec7df5550.clean/BuildTools" --force 
autoreconf: configure.ac: tracing
autoreconf: configure.ac: not using Libtool
autoreconf: configure.ac: not using Intltool
autoreconf: configure.ac: not using Gtkdoc
autoreconf: running: /usr/local/Cellar/autoconf/2.71/bin/autoconf --force
configure.ac:39: error: possibly undefined macro: AC_COIN_CREATE_LIBTOOL
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
configure.ac:45: error: possibly undefined macro: AC_COIN_MAIN_PACKAGEDIR
autoreconf: error: /usr/local/Cellar/autoconf/2.71/bin/autoconf failed with exit status: 1

@Neumann-A
Copy link
Contributor

You need to figure out where the missing macros should come from and set ac_local accordingly.

@jpfeuffer jpfeuffer mentioned this pull request May 24, 2023
Closed
jimwang118
jimwang118 previously approved these changes Jun 16, 2023
View reviewed changes
LilyWangLL
LilyWangLL requested changes Jun 16, 2023
View reviewed changes
ports/coin-or-cbc/portfile.cmake Outdated Show resolved Hide resolved
ports/coin-or-cbc/portfile.cmake Outdated Show resolved Hide resolved
ports/coin-or-cbc/portfile.cmake Outdated Show resolved Hide resolved
ports/coin-or-cbc/vcpkg.json Show resolved Hide resolved
@LilyWangLL
Copy link
Contributor

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@LilyWangLL LilyWangLL marked this pull request as draft June 16, 2023 02:39
jimwang118 and others added 2 commits June 16, 2023 10:46
@jimwang118
Merge branch 'master' of https://github.com/microsoft/vcpkg into addp…
394dc22 
…ort/cbc
@jpfeuffer @LilyWangLL
Apply suggestions from code review
756e530 
Co-authored-by: Lily Wang <94091114+LilyWangLL@users.noreply.github.com>
@jpfeuffer
Copy link
Contributor Author

Keeping logs:
With AUTOCONFIG + dep.patch for configure.ac:

autoreconf: export WARNINGS=
autoreconf: Entering directory '.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal -I "/mnt/vcpkg-ci/buildtrees/coin-or-cbc/src/970c621a3b-821838d561.clean/BuildTools" --force 
aclocal: error: couldn't open directory 'm4': No such file or directory
autoreconf: error: aclocal failed with exit status: 1

@jpfeuffer jpfeuffer marked this pull request as ready for review June 28, 2023 13:09
@dg0yt
Copy link
Contributor

dg0yt commented Jun 28, 2023 •
edited
Loading

To make it clear, I suggested the combination of:
without patching configure.ac
without AUTOCONFIG
with DETERMINE_BUILD_TRIPLET

@jpfeuffer
Copy link
Contributor Author

jpfeuffer commented Jun 28, 2023 •
edited
Loading

Can someone retrigger stalled CI? Edit: Finished!

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jun 30, 2023
@jpfeuffer
Copy link
Contributor Author

Hi! I was wondering if there is something missing. In any case, just bumping so this won't be forgotten.

@vicroms vicroms merged commit 84aba9a into microsoft:master Jul 5, 2023
15 checks passed
@jpfeuffer
Copy link
Contributor Author

Great! I want to thank everyone here for their help and that project in general!

@jpfeuffer jpfeuffer deleted the addport/cbc branch July 5, 2023 22:21
@dg0yt dg0yt mentioned this pull request Jun 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-lavrenov ilya-lavrenov ilya-lavrenov left review comments

@LilyWangLL LilyWangLL LilyWangLL approved these changes

@dg0yt dg0yt Awaiting requested review from dg0yt

@jimwang118 jimwang118 Awaiting requested review from jimwang118

Assignees

@LilyWangLL LilyWangLL

@jimwang118 jimwang118

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jpfeuffer @Neumann-A @dg0yt @jimwang118 @LilyWangLL @ilya-lavrenov @vicroms