[usockets] WolfSSL feature #32162
[usockets] WolfSSL feature #32162
Conversation
|
Reviews, any? |
|
It is one of the SSL implementations in uSockets, OpenSSL is not required to obtain that and SSL features can be obtained through OpenSS, WolfSSL or BoringSSL. Reasons not to use OpenSSL include reducing compile time/overheads. See uSockets |
|
@pierr3 You don't have to explain why you want to choose alternatives. The vcpkg maintainers must ensure that features are used correctly. Feature Really, this PR was merged without sufficient review. I don't know if usockets allows to choose backends at runtime. But the feature interface is invalid now IMO. |
|
|
||
| list(APPEND CMAKE_REQUIRED_INCLUDES ${OPENSSL_INCLUDE_DIR}) | ||
| else() | ||
| set(NOT_USE_WOLFSSL "-DLIBUS_NO_SSL") |
There was a problem hiding this comment.
This is set even if openssl is enabled. Does it meant that usockets[ssl] is broken now?
There was a problem hiding this comment.
usockets[ssl] is broken now.
@vicroms @BillyONeal Please revert, and return to proper reviews.
There was a problem hiding this comment.
My bad, this is a case of an alternative as a feature that should have been rejected per policy.
@pierr3 if you need to override the ssl selection please use an overlay port
|
Apologies for the confusion, thank you for the explanation, will review the features docs deeper next time. |
./vcpkg x-add-version --alland committing the result.This PR adds WolfSSL support as a feature for uSockets.