Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qt5-webengine] remove obsolete patches from qt5-webengine #32219

Merged
merged 4 commits into from
Jun 27, 2023
Merged

[qt5-webengine] remove obsolete patches from qt5-webengine #32219

merged 4 commits into from
Jun 27, 2023

Conversation

carsten-grimm-at-ipolog
Copy link
Contributor

@carsten-grimm-at-ipolog carsten-grimm-at-ipolog commented Jun 25, 2023 •
edited
Loading

Fixes #32218

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download (no updated downloads)
  • The "supports" clause reflects platforms that may be fixed by this new version (no change)
  • Any fixed CI baseline entries are removed from that file. (no changes to that file)
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

This fix removes two patches that no longer apply due to changes in Qt 5.15.10.

@carsten-grimm-at-ipolog carsten-grimm-at-ipolog changed the title Fix issue 32218 qt5 webengine remove obsolete patches [qt5-webengine] Fix issue 32218 qt5 webengine remove obsolete patches Jun 25, 2023
@carsten-grimm-at-ipolog carsten-grimm-at-ipolog changed the title [qt5-webengine] Fix issue 32218 qt5 webengine remove obsolete patches [qt5-webengine] remove obsolete patches from qt5-webengine Jun 25, 2023
@carsten-grimm-at-ipolog carsten-grimm-at-ipolog marked this pull request as ready for review June 25, 2023 12:53
@carsten-grimm-at-ipolog
Copy link
Contributor Author

Note that the command vcpkg x-add-version qt5-webengine moved the entry for baresip-libre in versions/baseline.json. This was not done manually.

@jimwang118 jimwang118 added the category:port-bug The issue is with a library, which is something the port should already support label Jun 26, 2023
@jimwang118
Copy link
Contributor

Compile test pass with following triplets:

x86-windows
x64-windows

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Jun 27, 2023
@vicroms vicroms merged commit e942f06 into microsoft:master Jun 27, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jimwang118 jimwang118

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[qt5-webengine] Build error
3 participants
@carsten-grimm-at-ipolog @jimwang118 @vicroms