-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nyan-lang] Add new port nyan-lang #32250
Conversation
Name should be nyan-lang |
Let me figure out what this means
|
Hi @Adela0814 , how should I handle these exe files? Should I put them under tools\ instead of bin\ ? |
Yes, please move the executable file to the |
Will contact upstream for build failures |
UWP builds are failing because SymInitialize is not available. |
Hi @Adela0814 , is there a way to detect UWP builds? I contacted upstream and the maintainers want to remove the usage of SymInitialize in UWP builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would still recommend switching to setting FLEX_EXECUTABLE
.
-if(WIN32) | ||
+if(WIN32 AND (NOT WINDOWS_STORE)) | ||
set_target_properties(nyan PROPERTIES WINDOWS_EXPORT_ALL_SYMBOLS ON) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If upstream really needs to export all symbols on Windows, can it really work without that on UWP?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure about the purpose of setting up symbols. It could be a "because we can" scenario here...
@dg0yt nyan/CMakeLists.txt has |
ports/nyan-lang/portfile.cmake
Outdated
cmake_path(GET FLEX PARENT_PATH FLEX_PATH) | ||
|
||
vcpkg_cmake_configure( | ||
SOURCE_PATH "${SOURCE_PATH}" | ||
OPTIONS | ||
"-DFLEX_ROOT=${FLEX_PATH}" | ||
-DCMAKE_POLICY_DEFAULT_CMP0074=NEW |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmake_path(GET FLEX PARENT_PATH FLEX_PATH) | |
vcpkg_cmake_configure( | |
SOURCE_PATH "${SOURCE_PATH}" | |
OPTIONS | |
"-DFLEX_ROOT=${FLEX_PATH}" | |
-DCMAKE_POLICY_DEFAULT_CMP0074=NEW | |
vcpkg_cmake_configure( | |
SOURCE_PATH "${SOURCE_PATH}" | |
OPTIONS | |
"-DFLEX_EXECUTABLE=${FLEX}" |
Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags. |
Yes. The package does a |
Applied suggested changes and rebased to latest master branch. |
Fixes 32249
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.