Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openssl] Use bash from PATH rather then /bin #32289

Merged
merged 2 commits into from
Jul 1, 2023
Merged

[openssl] Use bash from PATH rather then /bin #32289

merged 2 commits into from
Jul 1, 2023

Conversation

SchaichAlonso
Copy link
Contributor

Fixes #32288.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@SchaichAlonso
[openssl] Use bash from PATH rather then /bin (microsoft#32288)
35ce16e 
The configure script used to invoke python during the build process contains
a shebang that invokes /bin/bash independend of whatever bash would usually
resolve to.

This breaks compilation on FreeBSD, where bash isn't part of the operating
system.

Rather then /bin/bash, invoke /usr/bin/env bash, which resolves the bash
command by iterating PATH
@SchaichAlonso
[openssl] regenerate versions registries (microsoft#32288)
6213f15
@FrankXie05 FrankXie05 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jun 29, 2023
@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Jun 30, 2023
@vicroms vicroms merged commit 4a3c366 into microsoft:master Jul 1, 2023
15 checks passed
fwcd pushed a commit to fwcd/vcpkg that referenced this pull request Aug 21, 2023
@SchaichAlonso @fwcd
[openssl] Use bash from PATH rather then /bin (microsoft#32289)
7953011 
* [openssl] Use bash from PATH rather then /bin (microsoft#32288)

The configure script used to invoke python during the build process contains
a shebang that invokes /bin/bash independend of whatever bash would usually
resolve to.

This breaks compilation on FreeBSD, where bash isn't part of the operating
system.

Rather then /bin/bash, invoke /usr/bin/env bash, which resolves the bash
command by iterating PATH

* [openssl] regenerate versions registries (microsoft#32288)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankXie05 FrankXie05 FrankXie05 approved these changes

Assignees

@FrankXie05 FrankXie05

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[openssl] Use bash from PATH rather then /bin
3 participants
@SchaichAlonso @FrankXie05 @vicroms