Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sleepy-discord] Fix missing header #32367

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

Adela0814
Copy link
Contributor

@Adela0814 Adela0814 commented Jul 3, 2023

Fixes #32359
Error message:

/root/vcpkg/buildtrees/sleepy-discord/src/129fbab21b-0fb9b07de3.clean/sleepy_discord/zlib_compression.cpp:7:3: error: ‘memset’ was not declared in this scope
    7 |   memset(&stream, 0, sizeof(stream));
      |   ^~~~~~
/root/vcpkg/buildtrees/sleepy-discord/src/129fbab21b-0fb9b07de3.clean/sleepy_discord/zlib_compression.cpp:3:1: note: ‘memset’ is defined in header ‘<cstring>’; did you forget to ‘#include <cstring>’?
    2 | #include "zlib_compression.h"
  +++ |+#include <cstring>
    3 | 

I also submit an issue to upsteam, see yourWaifu/sleepy-discord#272.

Tested all feature on the following triplets:

  • x64-windows
  • x86-windows
  • x64-linux

Tested usage on x64-windows.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Adela0814 Adela0814 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jul 3, 2023
@Adela0814 Adela0814 marked this pull request as ready for review July 3, 2023 08:16
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Jul 3, 2023
@vicroms vicroms merged commit b990e95 into microsoft:master Jul 5, 2023
15 checks passed
@Adela0814 Adela0814 deleted the Dev/Mengna/sleep branch July 18, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sleepy-discord] Build failure
3 participants