Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cairo] update license info and add all licenses to copyright file #32430

Merged
merged 9 commits into from
Jul 11, 2023

Conversation

marcbull
Copy link
Contributor

@marcbull marcbull commented Jul 7, 2023

Cairo is licensed either under LGPL-2.1 OR MPL-1.1.

https://gitlab.freedesktop.org/cairo/cairo/-/blob/master/COPYING

  • [x ] Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@JonLiu1993 JonLiu1993 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jul 7, 2023
@marcbull
Copy link
Contributor Author

marcbull commented Jul 7, 2023

@microsoft-github-policy-service agree company="X-Software GmbH"

ports/cairo/vcpkg.json Outdated Show resolved Hide resolved
versions/c-/cairo.json Outdated Show resolved Hide resolved
@marcbull
Copy link
Contributor Author

marcbull commented Jul 7, 2023

@FrankXie05 do you think the PR is ready for review?

@FrankXie05
Copy link
Contributor

@marcbull No, you did not accept the changes I requested. :)

@marcbull marcbull requested a review from FrankXie05 July 7, 2023 07:57
Copy link
Contributor Author

@marcbull marcbull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepting changes

marcbull and others added 2 commits July 7, 2023 10:00
Co-authored-by: Frank <65999885+FrankXie05@users.noreply.github.com>
Co-authored-by: Frank <65999885+FrankXie05@users.noreply.github.com>
@@ -1362,7 +1362,7 @@
},
"cairo": {
"baseline": "1.17.8",
"port-version": 2
"port-version": 4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"port-version": 4
"port-version": 3

You need to run the command ./vcpkg x-add-version cairo

@FrankXie05
Copy link
Contributor

@marcbull Do you mind if I change this PR for you? :)

marcbull and others added 2 commits July 7, 2023 10:17
Co-authored-by: Frank <65999885+FrankXie05@users.noreply.github.com>
@marcbull
Copy link
Contributor Author

marcbull commented Jul 7, 2023

@marcbull Do you mind if I change this PR for you? :)

I just pushed a commit with the updated version database. I'm very sorry for any inconvenience, submitting to vcpkg is new for me. But I'm getting used to the workflow. Thanks for your help :)

@marcbull marcbull marked this pull request as ready for review July 10, 2023 04:57
@marcbull marcbull requested a review from FrankXie05 July 10, 2023 05:04
@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Jul 10, 2023
@BillyONeal BillyONeal merged commit efd6ced into microsoft:master Jul 11, 2023
15 checks passed
@BillyONeal
Copy link
Member

Thanks for making the license entry more accurate!

@marcbull marcbull deleted the cairo-dev branch July 11, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants