Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opencv4] fix feature ovis #32578

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

autoantwort
Copy link
Contributor

Fixes #32576
Submitted upstream opencv/opencv_contrib#3529

@Adela0814 Adela0814 added the category:port-bug The issue is with a library, which is something the port should already support label Jul 17, 2023
@Adela0814
Copy link
Contributor

Let's wait for the upstream response.

@BillyONeal BillyONeal added the depends:upstream-changes Waiting on a change to the upstream project label Jul 18, 2023
@autoantwort
Copy link
Contributor Author

@Adela0814 This change is independent of upstream. I have only submitted it upstream so that we don't have to update the patch the next time we update opencv4. Imho this should not block this PR.

@Adela0814
Copy link
Contributor

@Adela0814 This change is independent of upstream. I have only submitted it upstream so that we don't have to update the patch the next time we update opencv4. Imho this should not block this PR.

According to our strategy, this change requires notifying upstream and waiting for upstream response.
see: https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md#:~:text=Notify%20upstream%20owners,apply%20such%20patches.

@autoantwort
Copy link
Contributor Author

@Adela0814 no response from upstream since more than 30 days

@autoantwort autoantwort force-pushed the fix-ogre-dependency branch 4 times, most recently from 5ecc669 to 6abcecc Compare August 19, 2023 15:32
dan-shaw
dan-shaw previously approved these changes Aug 24, 2023
@dan-shaw dan-shaw merged commit ef19b3e into microsoft:master Aug 24, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support depends:upstream-changes Waiting on a change to the upstream project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[opencv4] Build failure
4 participants