Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skia] fix issue where vk_mem_alloc.h cannot find vulkan.h #32715

Closed
wants to merge 9 commits into from

Conversation

lconn-dev
Copy link

@lconn-dev lconn-dev commented Jul 24, 2023

Fixes #32706

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@lconn-dev lconn-dev mentioned this pull request Jul 24, 2023
@jimwang118 jimwang118 self-assigned this Jul 24, 2023
@lconn-dev
Copy link
Author

@lconn-dev please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@jimwang118
Copy link
Contributor

After fixing the vcpkg.json and portfile.cmake files, you need to run:./vcpkg.exe x-add-version {portname}command to update the version, and submit the updated version file together.

@lconn-dev lconn-dev marked this pull request as draft July 24, 2023 02:59
@lconn-dev
Copy link
Author

lconn-dev commented Jul 24, 2023

Sorry about that, this is my first PR. I think now these changes are correct.
Edit: looks like it's still having issues, I updated the version files manually but maybe the hash is incorrect. I'll try to do this on my machine instead of the github online editor.

@lconn-dev lconn-dev marked this pull request as ready for review July 24, 2023 03:03
@lconn-dev lconn-dev marked this pull request as draft July 24, 2023 03:14
@lconn-dev lconn-dev marked this pull request as ready for review July 24, 2023 03:37
@lconn-dev lconn-dev changed the title fix issue where vk_mem_alloc.h cannot find vulkan.h [skia] fix issue where vk_mem_alloc.h cannot find vulkan.h Jul 24, 2023
@jimwang118 jimwang118 added the category:port-bug The issue is with a library, which is something the port should already support label Jul 24, 2023
@jimwang118
Copy link
Contributor

The following error message appears when testing the installation locally.

CMake Error at ports/skia/portfile.cmake:183 (file):
  file COPY cannot find
  "F:/skia/installed/x64-windows-static/include/vulkan/vulkan.h": No error.
Call Stack (most recent call first):
  scripts/ports.cmake:147 (include)

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@jimwang118 jimwang118 marked this pull request as draft July 25, 2023 02:34
@dg0yt dg0yt mentioned this pull request Jul 25, 2023
7 tasks
@lconn-dev lconn-dev closed this Jul 25, 2023
@jimwang118
Copy link
Contributor

duplicate of #32740

@lconn-dev lconn-dev reopened this Jul 26, 2023
@lconn-dev
Copy link
Author

lconn-dev commented Jul 26, 2023

I still think #32740 is overall a better solution, however in interest of getting this fixed quickly, I've reopened this as a stop-gap alternative.

@lconn-dev lconn-dev marked this pull request as ready for review July 26, 2023 10:28
@dg0yt
Copy link
Contributor

dg0yt commented Jul 26, 2023

I still think #32740 is overall a better solution, however in interest of getting this fixed quickly, I've reopened this as a stop-gap alternative.

The other PR is ready as far as the fix is concerned. This PR will fail the same usage test: Using skia requires C++17.

@lconn-dev
Copy link
Author

Ah I see, closing this again. Thank you.

@lconn-dev lconn-dev closed this Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[skia] Build error
3 participants