Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[smpeg2] Cleanup, fix build, export config #32807

Merged
merged 5 commits into from
Aug 1, 2023
Merged

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jul 28, 2023

Alternative to #32794.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@MonicaLiu0311 MonicaLiu0311 added the category:port-bug The issue is with a library, which is something the port should already support label Jul 31, 2023
@dg0yt dg0yt changed the title [smpeg2] WIP [smpeg2] Cleanup, fix build, export config Jul 31, 2023
@dg0yt dg0yt marked this pull request as ready for review July 31, 2023 04:54
@dg0yt dg0yt marked this pull request as draft July 31, 2023 04:55
@dg0yt dg0yt marked this pull request as ready for review July 31, 2023 05:18
ports/smpeg2/portfile.cmake Outdated Show resolved Hide resolved
@MonicaLiu0311
Copy link
Contributor

The usage test passed on x64-windows (header files found):

smpeg2 provides CMake targets:

    # this is heuristically generated, and may not be correct
    find_package(unofficial-smpeg2 CONFIG REQUIRED)
    target_link_libraries(main PRIVATE unofficial::smpeg2::smpeg2)

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Aug 1, 2023
@JavierMatosD JavierMatosD merged commit 0895a81 into microsoft:master Aug 1, 2023
15 checks passed
@dg0yt dg0yt deleted the smpeg2 branch August 24, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants