Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mruby] New port #32847

Closed
wants to merge 6 commits into from
Closed

[mruby] New port #32847

wants to merge 6 commits into from

Conversation

diamant3
Copy link

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@diamant3
Copy link
Author

@microsoft-github-policy-service agree

@diamant3 diamant3 mentioned this pull request Jul 31, 2023
Open
@diamant3 diamant3 marked this pull request as ready for review July 31, 2023 07:15
@LilyWangLL LilyWangLL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jul 31, 2023
@LilyWangLL
Copy link
Contributor

This library doesn't install anything. How do users use it?

@LilyWangLL LilyWangLL marked this pull request as draft July 31, 2023 10:03
@LilyWangLL
Copy link
Contributor

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

dg0yt
dg0yt reviewed Aug 1, 2023
View reviewed changes
ports/mruby/portfile.cmake

set(VCPKG_POLICY_EMPTY_PACKAGE enabled)
vcpkg_execute_in_download_mode(
COMMAND rake
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't simply call some arbitrary rake. It is a dependency, and AFAIK there is no provider for it yet.

@LilyWangLL
Copy link
Contributor

Closing this PR since it seems that no progress is being made. Please ping us to reopen if work is still being done.

@LilyWangLL LilyWangLL closed this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

Assignees

@LilyWangLL LilyWangLL

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diamant3 @LilyWangLL @dg0yt