Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scotch] add new port #32859

Merged
merged 11 commits into from Aug 2, 2023
Merged

[scotch] add new port #32859

merged 11 commits into from Aug 2, 2023

Conversation

Neumann-A
Copy link
Contributor

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@Neumann-A Neumann-A marked this pull request as draft July 31, 2023 20:51
@Cheney-W Cheney-W self-assigned this Aug 1, 2023
@Cheney-W Cheney-W added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 1, 2023
@Neumann-A Neumann-A marked this pull request as ready for review August 1, 2023 12:08
@Cheney-W
Copy link
Contributor

Cheney-W commented Aug 2, 2023

    find_package(SCOTCH CONFIG REQUIRED)
    target_link_libraries(main PRIVATE SCOTCH::scotch SCOTCH::scotcherr SCOTCH::scotcherrexit)

Usage passed with following triplets:
x86-windows
x64-windows

@Cheney-W
Copy link
Contributor

Cheney-W commented Aug 2, 2023

@Neumann-A
Should the following folders also be deleted?

vcpkg\packages\scotch_x64-windows\man
vcpkg\packages\scotch_x64-windows\debug\man

@Cheney-W Cheney-W marked this pull request as draft August 2, 2023 07:29
@Cheney-W
Copy link
Contributor

Cheney-W commented Aug 2, 2023

Moving the PR to draft. When you respond, please revert to "ready for review".

@Neumann-A Neumann-A marked this pull request as ready for review August 2, 2023 10:00
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Aug 2, 2023
@JavierMatosD JavierMatosD merged commit 980ec0f into microsoft:master Aug 2, 2023
15 checks passed
@Neumann-A Neumann-A deleted the add_scotch branch August 2, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants