Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google-cloud-cpp] fix opentelemetry feature #32936

Merged
merged 1 commit into from Aug 4, 2023

Conversation

dbolduc
Copy link
Contributor

@dbolduc dbolduc commented Aug 3, 2023

cc @coryan - I goofed the original PR.

I only verified that opentelemetry-cpp was being installed as a dep. I did not verify that google_cloud_cpp_opentelemetry was installed.

Previously, google_cloud_cpp_opentelemetry was not listed as a target nor installed.

Now:

$ ./vcpkg install google-cloud-cpp[core,experimental-opentelemetry]
# <omitted>
google-cloud-cpp provides CMake targets:

    # this is heuristically generated, and may not be correct
    find_package(google_cloud_cpp_common CONFIG REQUIRED)
    target_link_libraries(main PRIVATE google-cloud-cpp::common)

    find_package(google_cloud_cpp_googleapis CONFIG REQUIRED)
    # note: 74 additional targets are not displayed.
    target_link_libraries(main PRIVATE gRPC::grpc gRPC::grpc++ google-cloud-cpp::iam_protos google-cloud-cpp::pubsub_protos)

    find_package(google_cloud_cpp_grpc_utils CONFIG REQUIRED)
    target_link_libraries(main PRIVATE google-cloud-cpp::grpc_utils)

    find_package(google_cloud_cpp_opentelemetry CONFIG REQUIRED)
    target_link_libraries(main PRIVATE google-cloud-cpp::experimental-opentelemetry)

    find_package(google_cloud_cpp_rest_internal CONFIG REQUIRED)
    target_link_libraries(main PRIVATE google-cloud-cpp::rest_internal)

    find_package(google_cloud_cpp_trace CONFIG REQUIRED)
    target_link_libraries(main PRIVATE google-cloud-cpp::trace google-cloud-cpp::trace_protos)

$ ls installed/x64-linux/share/ | grep google_cloud_cpp
google_cloud_cpp_common
google_cloud_cpp_googleapis
google_cloud_cpp_grpc_utils
google_cloud_cpp_opentelemetry
google_cloud_cpp_rest_internal
google_cloud_cpp_trace

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@dbolduc dbolduc marked this pull request as ready for review August 3, 2023 19:45
@Adela0814 Adela0814 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines labels Aug 4, 2023
@JavierMatosD JavierMatosD merged commit 3e7978b into microsoft:master Aug 4, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants