Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gperf] Fix error in cpp17 mode #32980

Merged
merged 5 commits into from Aug 7, 2023
Merged

[gperf] Fix error in cpp17 mode #32980

merged 5 commits into from Aug 7, 2023

Conversation

rdhafidh
Copy link
Contributor

@rdhafidh rdhafidh commented Aug 5, 2023

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

fixes #32979

@rdhafidh
Copy link
Contributor Author

rdhafidh commented Aug 5, 2023

@microsoft-github-policy-service agree

@Cheney-W Cheney-W self-assigned this Aug 7, 2023
@Cheney-W Cheney-W changed the title fix gperf in cpp17 mode [gperf] Fix error in cpp17 mode Aug 7, 2023
@Cheney-W Cheney-W added the category:port-bug The issue is with a library, which is something the port should already support label Aug 7, 2023
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Aug 7, 2023
@JavierMatosD JavierMatosD merged commit 56a44f3 into microsoft:master Aug 7, 2023
15 checks passed
@rdhafidh rdhafidh deleted the gperf branch August 7, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cheney-W Cheney-W Cheney-W approved these changes

Assignees

@Cheney-W Cheney-W

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[gperf] build failure
3 participants
@rdhafidh @Cheney-W @JavierMatosD