Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[imgui-sfml] Fix build and exported config #32982

Merged
merged 6 commits into from
Aug 7, 2023
Merged

[imgui-sfml] Fix build and exported config #32982

merged 6 commits into from
Aug 7, 2023

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Aug 5, 2023

Fixes #32977.
Merges overlapping patches.
Revises exported config and usage.

This was referenced Aug 5, 2023
Closed
Closed
@azias
Copy link

azias commented Aug 5, 2023

I confirm that it fixes #32977

@azias azias mentioned this pull request Aug 5, 2023
Merged
@MonicaLiu0311 MonicaLiu0311 added the category:port-bug The issue is with a library, which is something the port should already support label Aug 7, 2023
@MonicaLiu0311
Copy link
Contributor

The usage test passed on x64-windows (header files found):

imgui-sfml provides CMake targets:

    find_package(ImGui-SFML CONFIG REQUIRED)
    target_link_libraries(main PRIVATE ImGui-SFML::ImGui-SFML)

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Aug 7, 2023
@JavierMatosD JavierMatosD merged commit 3ee6678 into microsoft:master Aug 7, 2023
15 checks passed
@dg0yt dg0yt deleted the imgui-sfml branch August 7, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonicaLiu0311 MonicaLiu0311 MonicaLiu0311 approved these changes

Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[imgui-sfml:x64-mingw-dynamic] build failure
4 participants
@dg0yt @azias @MonicaLiu0311 @JavierMatosD