Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PCL compile tools #3301

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Conversation

claudiofantacci
Copy link
Contributor

@claudiofantacci claudiofantacci commented Apr 24, 2018

Add missing boost-related definition
add_definitions(-DBOOST_UUID_RANDOM_GENERATOR_COMPAT)
using a patch at configuration time.

Fixes #3289

Add missing boost definition using a patch.

Better compile from HEAD.
@ras0219-msft ras0219-msft merged commit f0767d3 into microsoft:master Apr 24, 2018
@ras0219-msft
Copy link
Contributor

Thanks for the PR!

@taketwo
Copy link

taketwo commented Jun 11, 2018

A fix for this issue was merged into PCL master, so the patch should be no longer needed.

@claudiofantacci
Copy link
Contributor Author

claudiofantacci commented Jun 11, 2018

A fix for this issue was merged into PCL master, so the patch should be no longer needed.

Great and thanks for reporting! 👍

The patch is still needed because is applied to PCL release 1.8.1. You may no longer need it if you install the port using --HEAD. In this case, however, the other patches need also to be checked as they may not be applicable anymore on the new version of their corresponding file on master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants