Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gmsh] update to 4.11.1 #33181

Merged
merged 4 commits into from
Aug 16, 2023
Merged

[gmsh] update to 4.11.1 #33181

merged 4 commits into from
Aug 16, 2023

Conversation

JonLiu1993
Copy link
Member

Fixes #33156

Update port gmsh to the latest version.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Tested feature graphics,occ,zipper successfully in the following triplet:

  • x64-windows
  • x64-windows-static

@JonLiu1993 JonLiu1993 added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Aug 15, 2023
@JonLiu1993 JonLiu1993 marked this pull request as ready for review August 15, 2023 09:12
@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Aug 16, 2023
@dan-shaw dan-shaw merged commit c50238a into microsoft:master Aug 16, 2023
15 checks passed
@JonLiu1993 JonLiu1993 deleted the dev/Jon/gmsh branch August 17, 2023 02:32
@Yanksi
Copy link

Yanksi commented Sep 20, 2023

Sorry this might be a stupid question. When I get gmsh installed with vcpkg, no hints was given for how can I include and link the gmsh library in my CmakeList. And I tried to do this with regular commands like

find_package (GMSH CONFIG REQUIRED)
target_link_libraries(my_project GMSH::GMSH)

Cmake just complains the configuration for gmsh could not be found with the following errors

[cmake]   Could not find a package configuration file provided by "GMSH" with any of
[cmake]   the following names:
[cmake] 
[cmake]     GMSHConfig.cmake
[cmake]     gmsh-config.cmake

Could you please tell me how can I do this correctly?

@JonLiu1993
Copy link
Member Author

@Yanksi, gmsh did not generate the *.cmkae file, so find_package (GMSH CONFIG REQUIRED) cannot be used, and I did not find Findgmsh.cmake in F:\vcpkg\downloads\tools\cmake-3.27.1-windows\cmake-3.27.1-windows-i386\share\cmake-3.27\Modules directory, so Module mode cannot be used. You can submit an issue and we will fix this problem.

@dg0yt
Copy link
Contributor

dg0yt commented Sep 21, 2023

You can use find_path and find_library.
You can submit an issue upstream, asking for exported CMake config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gmsh] update to 4.11.1
5 participants