-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[anari] Added ANARI port. #33213
[anari] Added ANARI port. #33213
Conversation
ports/anari/portfile.cmake
Outdated
vcpkg_minimum_required(VERSION 2022-10-12) # For ${PORT} and ${VERSION}. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary, please remove this,
ports/anari/portfile.cmake
Outdated
vcpkg_from_github( | ||
OUT_SOURCE_PATH SOURCE_PATH | ||
REPO KhronosGroup/ANARI-SDK | ||
REF v${VERSION} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
REF v${VERSION} | |
REF "v${VERSION}" |
ports/anari/portfile.cmake
Outdated
|
||
vcpkg_install_copyright( | ||
FILE_LIST "${SOURCE_PATH}/LICENSE" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a new line at the end of the file.
ports/anari/vcpkg.json
Outdated
"host": true | ||
} | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a new line at the end of the file.
You should run |
Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags. |
I am looking into the CI failures. I locally tested x86-windows and x64-windows and they seem to work. Edit: The CI seems to fail on line Edit: The only remaining error is:
This occurs in ARM64 debug mode, release works fine. I am looking for a solution. Edit: The error is due to MSVC or Embree. Disabling port on ARM64 Windows until it is fixed. Also, is it OK for the default implementation library (anari::helide) to depend on an internally downloaded version of Embree? Look at https://github.com/KhronosGroup/ANARI-SDK/blob/main/libs/helide/external/embree/CMakeLists.txt to see where this happens. I believe this is an intentional decision by Khronos; to have one "safe" device that works anywhere and does not depend on anything. If not, it is possible to disable it via |
I think its good to go. Checked the installation directories as a last step, everything looks clean. |
Please add the failed triplet to the |
Usage tested pass on |
Looks like this port is being a bad kitty and trying to recursively download inside the build. Also it's a bit scary that this isn't using the embree port |
I am looking into this now. The fastest way out is to disable the Helide implementation with Edit: Currently, the only real solution is |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.