Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libjxl] Fix Pkgconfig files are totally broken on x64-windows-static triplet #33422

Closed
wants to merge 16 commits into from
Closed

Conversation

jimwang118
Copy link
Contributor

@jimwang118 jimwang118 commented Aug 28, 2023

Fixes #33390
Fix the inconsistency between the name of the link library and the name of the compiled library in the PC file under static compilation

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Usage test pass with following triplets:

x64-windows
x64-windows-static

@jimwang118 jimwang118 changed the title [libjxl] Fix the inconsistency between the name of the link library and the name of the compiled library in the PC file under static compilation [libjxl] Fix Pkgconfig files are totally broken on x64-windows-static triplet Aug 28, 2023
@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Aug 28, 2023
@jimwang118 jimwang118 marked this pull request as ready for review August 29, 2023 02:10
JonLiu1993
JonLiu1993 previously approved these changes Aug 29, 2023
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Aug 29, 2023
@dan-shaw dan-shaw added depends:upstream-changes Waiting on a change to the upstream project and removed info:reviewed Pull Request changes follow basic guidelines labels Aug 29, 2023
@jimwang118
Copy link
Contributor Author

Upstream PR:libjxl/libjxl#2754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support depends:upstream-changes Waiting on a change to the upstream project info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libjxl] Pkgconfig files are totally broken on x64-windows-static triplet
3 participants