[ports.cmake] Remove unnecessary variables for better debug experience #33435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adela0814
added
the
category:code-cleanup
BillyONeal
approved these changes
Sep 6, 2023
|
I cancelled the build because:
|
|
Is it OK to merge this? (Not doing so because it's still in draft form) |
there is no haste needed in merging this. It forces a world rebuild so maybe it should be merged with another world rebuilding pr which is more important? |
|
Sure, but it disposes of a PR :) |
autoantwort
added a commit
to autoantwort/vcpkg
that referenced
this pull request
Oct 3, 2023
…rosoft#33435)" This reverts commit ced4b6d.
clementperon
pushed a commit
to clementperon/vcpkg
that referenced
this pull request
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes around 50 extra variables which are defined in
portfile.cmake. I don't think any of those are necessary.(It also removes accidental usage of these variables)