[foonathan-memory] Fix the conflict of libs that tool depend on #33651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankXie05
added
category:port-bug
LilyWangLL
previously approved these changes
Sep 11, 2023
BillyONeal
removed
the
info:reviewed
|
@FrankXie05 I observed that upstream already has a very similar change. I pushed changes to use that. If you agree with those edits, please mark the PR ready for review again :) |
BillyONeal
approved these changes
Sep 13, 2023
|
It looks like the upstream remove the static link. |
|
LGTM. :) |
|
cc @BillyONeal |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #33607
Annotate flang
/WHOLEARCHIVEto avoid symbol conflicts caused by loading all libs.Feature
toolhas been tested successfully onx64-uwp.SHA512s are updated for each updated downloadThe "supports" clause reflects platforms that may be fixed by this new versionAny fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.