Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openssl] added support for platforms without libdl #3368

Merged
merged 1 commit into from
Apr 28, 2018
Merged

[openssl] added support for platforms without libdl #3368

merged 1 commit into from
Apr 28, 2018

Conversation

qis
Copy link
Contributor

@qis qis commented Apr 28, 2018

Since some platforms lack a dl library, the vcpkg-cmake-wrapper.cmake script from the OpenSSL port should not indiscriminately add it to the link libraries list.

Tested on the following platforms with a project that uses LibSSH2:

  • Linux (WSL on Windows 10 1709)
  • FreeBSD (12.0-CURRENT r324496 amd64)

These changes have no effect on Windows builds.

P.S.: @ras0219-msft If you already have something better, just close this without commenting. :)

@ras0219-msft ras0219-msft merged commit 38d139c into microsoft:master Apr 28, 2018
@ras0219-msft
Copy link
Contributor

Thanks for making the PR, @qis!

@qis qis deleted the dev/qis/openssl branch May 16, 2018 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants