Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skia] Add dependency dlfcn-win32 for feature freetype on windows #33793

Merged
merged 2 commits into from Sep 18, 2023
Merged

[skia] Add dependency dlfcn-win32 for feature freetype on windows #33793

merged 2 commits into from Sep 18, 2023

Conversation

LilyWangLL
Copy link
Contributor

Fixes #33770, fix the build error:

C:\v\vcpkg4\buildtrees\skia\src\40cd0870fd-d070e87289.clean\src\ports\SkFontHost_FreeType.cpp(79): fatal error C1083: Cannot open include file: 'dlfcn.h': No such file or directory
ninja: build stopped: subcommand failed.

@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Sep 15, 2023
@LilyWangLL LilyWangLL marked this pull request as ready for review September 15, 2023 09:01
@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Sep 15, 2023
@vicroms vicroms merged commit 896155d into microsoft:master Sep 18, 2023
15 checks passed
@LilyWangLL LilyWangLL deleted the dev/LilyWang/issue33770 branch October 31, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankXie05 FrankXie05 FrankXie05 approved these changes

Assignees

@FrankXie05 FrankXie05

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[skia] Build failure
3 participants
@LilyWangLL @FrankXie05 @vicroms