Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libimobiledevice] Add tools feature #33872

Merged
merged 4 commits into from
Sep 29, 2023
Merged

[libimobiledevice] Add tools feature #33872

merged 4 commits into from
Sep 29, 2023

Conversation

xiaozhuai
Copy link
Contributor

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

See also #33246

@xiaozhuai xiaozhuai mentioned this pull request Sep 19, 2023
Merged
17 tasks
@xiaozhuai xiaozhuai force-pushed the dev-libimobiledevice branch 2 times, most recently from 3d95330 to b71c34b Compare September 19, 2023 14:25
@xiaozhuai xiaozhuai marked this pull request as draft September 19, 2023 14:49
@xiaozhuai xiaozhuai force-pushed the dev-libimobiledevice branch 2 times, most recently from 8670b26 to fd77139 Compare September 19, 2023 16:22
@xiaozhuai xiaozhuai marked this pull request as ready for review September 19, 2023 16:32
@FrankXie05 FrankXie05 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Sep 20, 2023
@xiaozhuai
Copy link
Contributor Author

@FrankXie05 Please review this pr.

@FrankXie05
Copy link
Contributor

Sorry, I forgot the label. 😅

@FrankXie05
Copy link
Contributor

The feature tools has been tested successfully locally.

@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Sep 26, 2023
@vicroms vicroms merged commit f0c6587 into microsoft:master Sep 29, 2023
15 checks passed
@xiaozhuai xiaozhuai deleted the dev-libimobiledevice branch October 5, 2023 09:05
clementperon pushed a commit to clementperon/vcpkg that referenced this pull request Oct 16, 2023
@xiaozhuai @clementperon
[libimobiledevice] Add tools feature (microsoft#33872)
94b5b18 
* [libimobiledevice] Add tools feature

* Update version database

* Remove tools from default-features

* Update version database
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankXie05 FrankXie05 FrankXie05 approved these changes

Assignees

@FrankXie05 FrankXie05

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xiaozhuai @FrankXie05 @vicroms