Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libjpeg-turbo] Disable simd/asm on Wasm #33951

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

playmer
Copy link
Contributor

@playmer playmer commented Sep 23, 2023

Noticed libjpeg-turbo was trying to build its asm code on Wasm which fails at link time. Disabling it on that target.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@playmer playmer marked this pull request as ready for review September 24, 2023 02:00
@dg0yt
Copy link
Contributor

dg0yt commented Sep 24, 2023

Please do these steps for proper versioning:

  1. revert the changes in versions/
  2. increment port-version in ports/libjpeg-turbo/vcpkg.json, and commit this change.
  3. run vcpkg x-add-version libjpeg-turbo, and commit the new changes.

@JonLiu1993 JonLiu1993 self-assigned this Sep 25, 2023
@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Sep 25, 2023
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Sep 26, 2023
@vicroms vicroms merged commit 4d07057 into microsoft:master Sep 26, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants