Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kf5texteditor] Create a new port with v5.98.0 #34378

Merged
merged 11 commits into from
Oct 31, 2023

Conversation

luncliff
Copy link
Contributor

@luncliff luncliff commented Oct 9, 2023

Changes

Resolve #33315

Checklist

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@luncliff luncliff marked this pull request as draft October 9, 2023 16:40
@JonLiu1993 JonLiu1993 self-assigned this Oct 10, 2023
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Oct 10, 2023
@JonLiu1993
Copy link
Member

@luncliff, Thanks for your PR, this is ci test error log, please take a look:

CMake Error at D:/downloads/tools/cmake-3.27.1-windows/cmake-3.27.1-windows-i386/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Gettext (missing: GETTEXT_MSGMERGE_EXECUTABLE
  GETTEXT_MSGFMT_EXECUTABLE)

ports/kf5texteditor/vcpkg.json Outdated Show resolved Hide resolved
ports/kf5texteditor/portfile.cmake Outdated Show resolved Hide resolved
Co-authored-by: Kai Pastor <dg0yt@darc.de>
@luncliff
Copy link
Contributor Author

For some reason my Windows environment fails to install gettext and gettext-libintl in x64-windows, x64-windows-static. It may take 2~3 more days...

@luncliff luncliff marked this pull request as ready for review October 28, 2023 14:47
@luncliff
Copy link
Contributor Author

It took some time to relocate *.desktop files from other kf5* ports

@luncliff luncliff requested a review from dg0yt October 31, 2023 05:16
@JonLiu1993
Copy link
Member

Tested usage successfully by kf5texteditor:x64-windows:

kf5texteditor provides CMake targets:

  # this is heuristically generated, and may not be correct
  find_package(KF5TextEditor CONFIG REQUIRED)
  target_link_libraries(main PRIVATE KF5::TextEditor)

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Oct 31, 2023
@JavierMatosD JavierMatosD merged commit 83a4bd8 into microsoft:master Oct 31, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] <KF5TextEditor>
4 participants