-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gz-rendering7] new port #34618
[gz-rendering7] new port #34618
Conversation
c4c0233
to
07ff610
Compare
0c44d41
to
e48a83a
Compare
Usage test pass with following triplets:
|
it still works in progress |
Do not merge.
|
@dg0yt I got an error on linux on this port. I will report it here when I can. |
@dg0yt Can I ask your help?
I am not sure how to solve it. This error is not connected to your changes. |
@jimwang118 @dg0yt @MonicaLiu0311 |
you refer to ogre-next... yes, depending on it means having no CI. And not getting a new port. You need to export I won't do anything before #34667 is merged. I look at one problem and find two more. This doesn't scale well... |
I am waiting for your PR will merge. |
You should use the |
28ccacc
to
6fec729
Compare
I added similar line as here: And I still get the same error. What should I do? |
You need |
@dg0yt Thank you for your help. install(TARGETS "terra" EXPORT terra)
install(EXPORT terra DESTINATION ${GZ_RENDERING_ENGINE_INSTALL_DIR}) And I got the same error. |
6fec729
to
c1373bc
Compare
@dg0yt I got it. Thank you for your help. |
@jimwang118 It ready for review. |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.