-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opencv] added openvino support #34727
Conversation
whatever this PR did, it increased build time, broke many ci pipelines and expanded a lot the dependencies without user notice. This OpenVINO addition should at least have been an optional feature... I am surprised in CI here there is nothing highlighted, because for me it's broken now on all OSes |
Hi @cenit
If you don't use dnn module, you can explicitly disable this feature as it always recommended for final vcpkg users. |
Strongly agree. In any sense, bloating build time by 10x is ruining the user experience. Imagine newbie vcpkg users ending up telling others "installing opencv via vcpkg is absurdly slow, get away from it!" @cenit I know you have been doing a really good job maintaining the opencv port for years, please keep going😍😍😍
@ilya-lavrenov No, you break the rule here, at least for this port. We should carefully choose a small subset of features as default, make all others optional, then let users add their desired ones. OpenVINO support is great, but it should be optional. |
@ilya-lavrenov opencv[dnn] is now not buildable on a standard github action windows runner, this is really impacting us. this is the tail of /c/b/openvino/install-x64-windows-release-rel-out.log
|
Thanks for your feedback. I'm turning OpenVINO as optional feature in the PR #34889 |
Reason: Optimized OpenCV DNN module with OpenVINO, because by default OpenCV DNN module is slow as does not have any integrated performant backend.
Closes #28357
./vcpkg x-add-version --all
and committing the result.END OF PORT UPDATE CHECKLIST (delete this line) -->