Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7zip] Add C headers to includes #34828

Merged
merged 6 commits into from Nov 8, 2023

Conversation

judemille
Copy link
Contributor

The current 7zip port only adds the CPP headers to the includes. This PR adds the C headers, for consumers that need that.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download (not applicable)
  • The "supports" clause reflects platforms that may be fixed by this new version (not applicable)
  • Any fixed CI baseline entries are removed from that file. (no changes here)
  • Any patches that are no longer applied are deleted from the port's directory. (no changes)
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

The 7zip version 23.01 has been overridden. This can be changed if necessary.

@Osyotr
Copy link
Contributor

Osyotr commented Oct 31, 2023

The 7zip version 23.01 has been overridden. This can be changed if necessary.

Please bump port-version. https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md#update-the-port-version-field-in-the-manifest-file-of-any-modified-ports

"port-version": 1
},
{
"git-tree": "dad5a164db0226aeca0477b350044c66324b2dca",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not supposed to change. I'm not sure what's the easiest way to fix this, but I would revert changes in this file and baseline.json and then call vcpkg x-add-version 7zip

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed that. Will squash commits if desired, though I'm not sure how that can be done in a manner that keeps vcpkg happy.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs in this repo are automatically squashed when merged. Note that these values are not commit hashes, but git tree hashes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see.

@jimwang118 jimwang118 self-assigned this Nov 1, 2023
@jimwang118 jimwang118 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Nov 1, 2023
@judemille
Copy link
Contributor Author

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Nov 8, 2023
@JavierMatosD JavierMatosD merged commit f268ef2 into microsoft:master Nov 8, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants