New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7zip] Add C headers to includes #34828
[7zip] Add C headers to includes #34828
Conversation
Please bump |
versions/7-/7zip.json
Outdated
"port-version": 1 | ||
}, | ||
{ | ||
"git-tree": "dad5a164db0226aeca0477b350044c66324b2dca", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not supposed to change. I'm not sure what's the easiest way to fix this, but I would revert changes in this file and baseline.json
and then call vcpkg x-add-version 7zip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed that. Will squash commits if desired, though I'm not sure how that can be done in a manner that keeps vcpkg happy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PRs in this repo are automatically squashed when merged. Note that these values are not commit hashes, but git tree hashes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see.
The current 7zip port only adds the CPP headers to the includes. This PR adds the C headers, for consumers that need that.
./vcpkg x-add-version --all
and committing the result.The 7zip version 23.01 has been overridden. This can be changed if necessary.